Skip to content

Commit 65d7e45

Browse files
committed
Refactor to improve FlavorDimension extensibility, and replace to register lazy api.
Change-Id: I6e2980f19da5a6e22a7773c84493424663e33fc4
1 parent c0f9660 commit 65d7e45

File tree

1 file changed

+6
-3
lines changed
  • build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid

1 file changed

+6
-3
lines changed

build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/NiaFlavor.kt

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,16 @@ enum class NiaFlavor(val dimension: FlavorDimension, val applicationIdSuffix: St
2121

2222
fun configureFlavors(
2323
commonExtension: CommonExtension<*, *, *, *, *, *>,
24-
flavorConfigurationBlock: ProductFlavor.(flavor: NiaFlavor) -> Unit = {}
24+
flavorConfigurationBlock: ProductFlavor.(flavor: NiaFlavor) -> Unit = {},
2525
) {
2626
commonExtension.apply {
27-
flavorDimensions += FlavorDimension.contentType.name
27+
FlavorDimension.values().forEach {
28+
flavorDimensions += it.name
29+
}
30+
2831
productFlavors {
2932
NiaFlavor.values().forEach {
30-
create(it.name) {
33+
register(it.name) {
3134
dimension = it.dimension.name
3235
flavorConfigurationBlock(this, it)
3336
if (this@apply is ApplicationExtension && this is ApplicationProductFlavor) {

0 commit comments

Comments
 (0)