Skip to content

Commit 756e45e

Browse files
committed
Add note about b/221643630
1 parent 501d29b commit 756e45e

File tree

1 file changed

+4
-3
lines changed
  • feature/settings/src/main/java/com/google/samples/apps/nowinandroid/feature/settings

1 file changed

+4
-3
lines changed

feature/settings/src/main/java/com/google/samples/apps/nowinandroid/feature/settings/SettingsViewModel.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,11 @@ class SettingsViewModel @Inject constructor(
4848
.stateIn(
4949
scope = viewModelScope,
5050
// Starting eagerly means the user data is ready when the SettingsDialog is laid out
51-
// for the first time. Without this the layout is done using the "Loading" text,
52-
// then replaced with the user editable fields once loaded, however, the layout
53-
// height doesn't change meaning all the fields are squashed into a small
51+
// for the first time. Without this, due to b/221643630 the layout is done using the
52+
// "Loading" text, then replaced with the user editable fields once loaded, however,
53+
// the layout height doesn't change meaning all the fields are squashed into a small
5454
// scrollable column.
55+
// TODO: Change to SharingStarted.WhileSubscribed(5_000) when b/221643630 is fixed
5556
started = SharingStarted.Eagerly,
5657
initialValue = Loading
5758
)

0 commit comments

Comments
 (0)