Skip to content

Commit 7e0bfb4

Browse files
committed
Add missing binding in NetworkModule
1 parent b5d3424 commit 7e0bfb4

File tree

4 files changed

+27
-13
lines changed
  • core
    • data/src/main/java/com/google/samples/apps/nowinandroid/core/data/di
    • network/src

4 files changed

+27
-13
lines changed

core/data/src/main/java/com/google/samples/apps/nowinandroid/core/data/di/DataModule.kt

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package com.google.samples.apps.nowinandroid.core.data.di
1818

19-
import android.content.Context
2019
import com.google.samples.apps.nowinandroid.core.data.repository.AuthorsRepository
2120
import com.google.samples.apps.nowinandroid.core.data.repository.NewsRepository
2221
import com.google.samples.apps.nowinandroid.core.data.repository.OfflineFirstAuthorsRepository
@@ -27,27 +26,15 @@ import com.google.samples.apps.nowinandroid.core.data.repository.TopicsRepositor
2726
import com.google.samples.apps.nowinandroid.core.data.repository.UserDataRepository
2827
import com.google.samples.apps.nowinandroid.core.data.util.ConnectivityManagerNetworkMonitor
2928
import com.google.samples.apps.nowinandroid.core.data.util.NetworkMonitor
30-
import com.google.samples.apps.nowinandroid.core.network.fake.FakeAssetManager
3129
import dagger.Binds
3230
import dagger.Module
33-
import dagger.Provides
3431
import dagger.hilt.InstallIn
35-
import dagger.hilt.android.qualifiers.ApplicationContext
3632
import dagger.hilt.components.SingletonComponent
37-
import javax.inject.Singleton
3833

3934
@Module
4035
@InstallIn(SingletonComponent::class)
4136
interface DataModule {
4237

43-
companion object {
44-
@Provides
45-
@Singleton
46-
fun providesFakeAssetManager(
47-
@ApplicationContext context: Context
48-
): FakeAssetManager = FakeAssetManager(context.assets::open)
49-
}
50-
5138
@Binds
5239
fun bindsTopicRepository(
5340
topicsRepository: OfflineFirstTopicsRepository

core/network/src/benchmark/java/com/google/samples/apps/nowinandroid/core/network/di/NetworkModule.kt

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,14 @@
1616

1717
package com.google.samples.apps.nowinandroid.core.network.di
1818

19+
import android.content.Context
1920
import com.google.samples.apps.nowinandroid.core.network.NiANetwork
21+
import com.google.samples.apps.nowinandroid.core.network.fake.FakeAssetManager
2022
import com.google.samples.apps.nowinandroid.core.network.fake.FakeNiANetwork
2123
import dagger.Binds
2224
import dagger.Module
2325
import dagger.Provides
26+
import dagger.hilt.android.qualifiers.ApplicationContext
2427
import dagger.hilt.InstallIn
2528
import dagger.hilt.components.SingletonComponent
2629
import javax.inject.Singleton
@@ -41,5 +44,11 @@ interface NetworkModule {
4144
fun providesNetworkJson(): Json = Json {
4245
ignoreUnknownKeys = true
4346
}
47+
48+
@Provides
49+
@Singleton
50+
fun providesFakeAssetManager(
51+
@ApplicationContext context: Context
52+
): FakeAssetManager = FakeAssetManager(context.assets::open)
4453
}
4554
}

core/network/src/demo/java/com/google/samples/apps/nowinandroid/core/network/di/NetworkModule.kt

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,15 @@
1616

1717
package com.google.samples.apps.nowinandroid.core.network.di
1818

19+
import android.content.Context
1920
import com.google.samples.apps.nowinandroid.core.network.NiaNetworkDataSource
21+
import com.google.samples.apps.nowinandroid.core.network.fake.FakeAssetManager
2022
import com.google.samples.apps.nowinandroid.core.network.fake.FakeNiaNetworkDataSource
2123
import dagger.Binds
2224
import dagger.Module
2325
import dagger.Provides
2426
import dagger.hilt.InstallIn
27+
import dagger.hilt.android.qualifiers.ApplicationContext
2528
import dagger.hilt.components.SingletonComponent
2629
import javax.inject.Singleton
2730
import kotlinx.serialization.json.Json
@@ -41,5 +44,11 @@ interface NetworkModule {
4144
fun providesNetworkJson(): Json = Json {
4245
ignoreUnknownKeys = true
4346
}
47+
48+
@Provides
49+
@Singleton
50+
fun providesFakeAssetManager(
51+
@ApplicationContext context: Context,
52+
): FakeAssetManager = FakeAssetManager(context.assets::open)
4453
}
4554
}

core/network/src/prod/java/com/google/samples/apps/nowinandroid/core/network/di/NetworkModule.kt

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,14 @@
1616

1717
package com.google.samples.apps.nowinandroid.core.network.di
1818

19+
import android.content.Context
20+
import com.google.samples.apps.nowinandroid.core.network.fake.FakeAssetManager
1921
import com.google.samples.apps.nowinandroid.core.network.NiaNetworkDataSource
2022
import com.google.samples.apps.nowinandroid.core.network.retrofit.RetrofitNiaNetwork
2123
import dagger.Binds
2224
import dagger.Module
2325
import dagger.Provides
26+
import dagger.hilt.android.qualifiers.ApplicationContext
2427
import dagger.hilt.InstallIn
2528
import dagger.hilt.components.SingletonComponent
2629
import javax.inject.Singleton
@@ -41,5 +44,11 @@ interface NetworkModule {
4144
fun providesNetworkJson(): Json = Json {
4245
ignoreUnknownKeys = true
4346
}
47+
48+
@Provides
49+
@Singleton
50+
fun providesFakeAssetManager(
51+
@ApplicationContext context: Context,
52+
): FakeAssetManager = FakeAssetManager(context.assets::open)
4453
}
4554
}

0 commit comments

Comments
 (0)