Skip to content

Commit 8bb823e

Browse files
committed
use backgroundScope
Change-Id: I78d5e53d343dac7e7d27896c95714a53a9a7229a
1 parent 94f86b7 commit 8bb823e

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

feature/bookmarks/src/test/kotlin/com/google/samples/apps/nowinandroid/feature/bookmarks/BookmarksViewModelTest.kt

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ class BookmarksViewModelTest {
9393

9494
@Test
9595
fun feedUiState_resourceIsViewed_setResourcesViewed() = runTest {
96-
val collectJob = launch(UnconfinedTestDispatcher()) { viewModel.feedUiState.collect() }
96+
backgroundScope.launch(UnconfinedTestDispatcher()) { viewModel.feedUiState.collect() }
9797

9898
// Given
9999
newsRepository.sendNewsResources(newsResourcesTestData)
@@ -109,13 +109,11 @@ class BookmarksViewModelTest {
109109
val item = viewModel.feedUiState.value
110110
assertIs<Success>(item)
111111
assertTrue(item.feed.first().hasBeenViewed)
112-
113-
collectJob.cancel()
114112
}
115113

116114
@Test
117115
fun feedUiState_undoneBookmarkRemoval_bookmarkIsRestored() = runTest {
118-
val collectJob = launch(UnconfinedTestDispatcher()) { viewModel.feedUiState.collect() }
116+
launch(UnconfinedTestDispatcher()) { viewModel.feedUiState.collect() }
119117

120118
// Given
121119
newsRepository.sendNewsResources(newsResourcesTestData)
@@ -134,7 +132,5 @@ class BookmarksViewModelTest {
134132
val item = viewModel.feedUiState.value
135133
assertIs<Success>(item)
136134
assertEquals(1, item.feed.size)
137-
138-
collectJob.cancel()
139135
}
140136
}

0 commit comments

Comments
 (0)