Skip to content

Commit a152149

Browse files
authored
Merge pull request #1947 from Jaehwa-Noh/gradle-to-gradle-api
Replace gradle to gradle-api.
2 parents 679da1c + 17100a4 commit a152149

File tree

8 files changed

+11
-11
lines changed

8 files changed

+11
-11
lines changed

build-logic/convention/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ kotlin {
3737
}
3838

3939
dependencies {
40-
compileOnly(libs.android.gradlePlugin)
40+
compileOnly(libs.android.gradleApiPlugin)
4141
compileOnly(libs.android.tools.common)
4242
compileOnly(libs.compose.gradlePlugin)
4343
compileOnly(libs.firebase.crashlytics.gradlePlugin)

build-logic/convention/src/main/kotlin/AndroidApplicationConventionPlugin.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
import com.android.build.api.dsl.ApplicationExtension
1818
import com.android.build.api.variant.ApplicationAndroidComponentsExtension
19-
import com.android.build.gradle.BaseExtension
2019
import com.google.samples.apps.nowinandroid.configureBadgingTasks
2120
import com.google.samples.apps.nowinandroid.configureGradleManagedDevices
2221
import com.google.samples.apps.nowinandroid.configureKotlinAndroid
@@ -44,7 +43,7 @@ class AndroidApplicationConventionPlugin : Plugin<Project> {
4443
}
4544
extensions.configure<ApplicationAndroidComponentsExtension> {
4645
configurePrintApksTask(this)
47-
configureBadgingTasks(extensions.getByType<BaseExtension>(), this)
46+
configureBadgingTasks(extensions.getByType<ApplicationExtension>(), this)
4847
}
4948
}
5049
}

build-logic/convention/src/main/kotlin/AndroidFeatureConventionPlugin.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
import com.android.build.gradle.LibraryExtension
17+
import com.android.build.api.dsl.LibraryExtension
1818
import com.google.samples.apps.nowinandroid.configureGradleManagedDevices
1919
import com.google.samples.apps.nowinandroid.libs
2020
import org.gradle.api.Plugin

build-logic/convention/src/main/kotlin/AndroidLibraryComposeConventionPlugin.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
import com.android.build.gradle.LibraryExtension
17+
import com.android.build.api.dsl.LibraryExtension
1818
import com.google.samples.apps.nowinandroid.configureAndroidCompose
1919
import org.gradle.api.Plugin
2020
import org.gradle.api.Project

build-logic/convention/src/main/kotlin/AndroidLibraryConventionPlugin.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
* limitations under the License.
1515
*/
1616

17+
import com.android.build.api.dsl.LibraryExtension
1718
import com.android.build.api.variant.LibraryAndroidComponentsExtension
18-
import com.android.build.gradle.LibraryExtension
1919
import com.google.samples.apps.nowinandroid.configureFlavors
2020
import com.google.samples.apps.nowinandroid.configureGradleManagedDevices
2121
import com.google.samples.apps.nowinandroid.configureKotlinAndroid
@@ -37,7 +37,8 @@ class AndroidLibraryConventionPlugin : Plugin<Project> {
3737

3838
extensions.configure<LibraryExtension> {
3939
configureKotlinAndroid(this)
40-
defaultConfig.targetSdk = 35
40+
testOptions.targetSdk = 35
41+
lint.targetSdk = 35
4142
defaultConfig.testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
4243
testOptions.animationsDisabled = true
4344
configureFlavors(this)

build-logic/convention/src/main/kotlin/AndroidTestConventionPlugin.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
import com.android.build.gradle.TestExtension
17+
import com.android.build.api.dsl.TestExtension
1818
import com.google.samples.apps.nowinandroid.configureGradleManagedDevices
1919
import com.google.samples.apps.nowinandroid.configureKotlinAndroid
2020
import org.gradle.api.Plugin

build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/Badging.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ package com.google.samples.apps.nowinandroid
1818

1919
import com.android.SdkConstants
2020
import com.android.build.api.artifact.SingleArtifact
21+
import com.android.build.api.dsl.ApplicationExtension
2122
import com.android.build.api.variant.ApplicationAndroidComponentsExtension
22-
import com.android.build.gradle.BaseExtension
2323
import com.google.common.truth.Truth.assertWithMessage
2424
import org.gradle.api.DefaultTask
2525
import org.gradle.api.Project
@@ -110,7 +110,7 @@ private fun String.capitalized() = replaceFirstChar {
110110
}
111111

112112
fun Project.configureBadgingTasks(
113-
baseExtension: BaseExtension,
113+
baseExtension: ApplicationExtension,
114114
componentsExtension: ApplicationAndroidComponentsExtension,
115115
) {
116116
// Registers a callback to be called, when a new variant is configured

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ truth = { group = "com.google.truth", name = "truth", version.ref = "truth" }
153153
turbine = { group = "app.cash.turbine", name = "turbine", version.ref = "turbine" }
154154

155155
# Dependencies of the included build-logic
156-
android-gradlePlugin = { group = "com.android.tools.build", name = "gradle", version.ref = "androidGradlePlugin" }
156+
android-gradleApiPlugin = { group = "com.android.tools.build", name = "gradle-api", version.ref = "androidGradlePlugin" }
157157
android-tools-common = { group = "com.android.tools", name = "common", version.ref = "androidTools" }
158158
compose-gradlePlugin = { module = "org.jetbrains.kotlin:compose-compiler-gradle-plugin", version.ref = "kotlin" }
159159
firebase-crashlytics-gradlePlugin = { group = "com.google.firebase", name = "firebase-crashlytics-gradle", version.ref = "firebaseCrashlyticsPlugin" }

0 commit comments

Comments
 (0)