Skip to content

Commit c730cf2

Browse files
committed
Use SdkConstants for getting aapt2 executable location
Change-Id: Ibc9ece0c3ade51a29954caee3af3a669ed99c384
1 parent 3ccacba commit c730cf2

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

build-logic/convention/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ tasks.withType<KotlinCompile>().configureEach {
3636

3737
dependencies {
3838
compileOnly(libs.android.gradlePlugin)
39+
compileOnly(libs.android.tools.common)
3940
compileOnly(libs.firebase.crashlytics.gradlePlugin)
4041
compileOnly(libs.firebase.performance.gradlePlugin)
4142
compileOnly(libs.kotlin.gradlePlugin)

build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/Badging.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ package com.google.samples.apps.nowinandroid
1919
import com.android.build.api.artifact.SingleArtifact
2020
import com.android.build.api.variant.ApplicationAndroidComponentsExtension
2121
import com.android.build.gradle.BaseExtension
22+
import com.android.SdkConstants
2223
import org.gradle.api.DefaultTask
2324
import org.gradle.api.GradleException
2425
import org.gradle.api.Project
@@ -113,7 +114,9 @@ fun Project.configureBadgingTasks(
113114
aapt2Executable.set(
114115
File(
115116
baseExtension.sdkDirectory,
116-
"build-tools/${baseExtension.buildToolsVersion}/aapt2",
117+
"${SdkConstants.FD_BUILD_TOOLS}/" +
118+
"${baseExtension.buildToolsVersion}/" +
119+
SdkConstants.FN_AAPT2,
117120
),
118121
)
119122

gradle/libs.versions.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
[versions]
22
accompanist = "0.32.0"
33
androidDesugarJdkLibs = "2.0.3"
4+
# AGP and tools should be updated together
45
androidGradlePlugin = "8.1.2"
6+
androidTools = "31.1.2"
57
androidxActivity = "1.8.0"
68
androidxAppCompat = "1.6.1"
79
androidxBrowser = "1.6.0"
@@ -139,6 +141,7 @@ turbine = { group = "app.cash.turbine", name = "turbine", version.ref = "turbine
139141

140142
# Dependencies of the included build-logic
141143
android-gradlePlugin = { group = "com.android.tools.build", name = "gradle", version.ref = "androidGradlePlugin" }
144+
android-tools-common = { group = "com.android.tools", name = "common", version.ref = "androidTools" }
142145
firebase-crashlytics-gradlePlugin = { group = "com.google.firebase", name = "firebase-crashlytics-gradle", version.ref = "firebaseCrashlyticsPlugin" }
143146
firebase-performance-gradlePlugin = { group = "com.google.firebase", name = "perf-plugin", version.ref = "firebasePerfPlugin" }
144147
kotlin-gradlePlugin = { group = "org.jetbrains.kotlin", name = "kotlin-gradle-plugin", version.ref = "kotlin" }

0 commit comments

Comments
 (0)