Skip to content

Commit cf2db95

Browse files
committed
Restore into a plain String text.
Change-Id: I3f4ead0be88ed460de007dae7b53c4d2f6c2249b
1 parent f422b85 commit cf2db95

File tree

8 files changed

+29
-43
lines changed

8 files changed

+29
-43
lines changed

build-logic/convention/src/main/kotlin/AndroidApplicationFirebaseConventionPlugin.kt

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
import com.android.build.api.dsl.ApplicationExtension
1818
import com.google.firebase.crashlytics.buildtools.gradle.CrashlyticsExtension
19-
import com.google.samples.apps.nowinandroid.implementation
2019
import com.google.samples.apps.nowinandroid.libs
2120
import org.gradle.api.Plugin
2221
import org.gradle.api.Project
@@ -35,9 +34,9 @@ class AndroidApplicationFirebaseConventionPlugin : Plugin<Project> {
3534

3635
dependencies {
3736
val bom = libs.findLibrary("firebase-bom").get()
38-
implementation(platform(bom))
39-
implementation(libs.findLibrary("firebase.analytics").get())
40-
implementation(libs.findLibrary("firebase.performance").get()) {
37+
"implementation"(platform(bom))
38+
"implementation"(libs.findLibrary("firebase.analytics").get())
39+
"implementation"(libs.findLibrary("firebase.performance").get()) {
4140
/*
4241
Exclusion of protobuf / protolite dependencies is necessary as the
4342
datastore-proto brings in protobuf dependencies. These are the source of truth
@@ -47,7 +46,7 @@ class AndroidApplicationFirebaseConventionPlugin : Plugin<Project> {
4746
exclude(group = "com.google.protobuf", module = "protobuf-javalite")
4847
exclude(group = "com.google.firebase", module = "protolite-well-known-types")
4948
}
50-
implementation(libs.findLibrary("firebase.crashlytics").get())
49+
"implementation"(libs.findLibrary("firebase.crashlytics").get())
5150
}
5251

5352
extensions.configure<ApplicationExtension> {

build-logic/convention/src/main/kotlin/AndroidFeatureConventionPlugin.kt

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,8 @@
1515
*/
1616

1717
import com.android.build.gradle.LibraryExtension
18-
import com.google.samples.apps.nowinandroid.androidTestImplementation
1918
import com.google.samples.apps.nowinandroid.configureGradleManagedDevices
20-
import com.google.samples.apps.nowinandroid.implementation
2119
import com.google.samples.apps.nowinandroid.libs
22-
import com.google.samples.apps.nowinandroid.testImplementation
2320
import org.gradle.api.Plugin
2421
import org.gradle.api.Project
2522
import org.gradle.kotlin.dsl.configure
@@ -39,18 +36,18 @@ class AndroidFeatureConventionPlugin : Plugin<Project> {
3936
}
4037

4138
dependencies {
42-
implementation(project(":core:ui"))
43-
implementation(project(":core:designsystem"))
39+
"implementation"(project(":core:ui"))
40+
"implementation"(project(":core:designsystem"))
4441

45-
implementation(libs.findLibrary("androidx.hilt.navigation.compose").get())
46-
implementation(libs.findLibrary("androidx.lifecycle.runtimeCompose").get())
47-
implementation(libs.findLibrary("androidx.lifecycle.viewModelCompose").get())
48-
implementation(libs.findLibrary("androidx.navigation.compose").get())
49-
implementation(libs.findLibrary("androidx.tracing.ktx").get())
50-
implementation(libs.findLibrary("kotlinx.serialization.json").get())
42+
"implementation"(libs.findLibrary("androidx.hilt.navigation.compose").get())
43+
"implementation"(libs.findLibrary("androidx.lifecycle.runtimeCompose").get())
44+
"implementation"(libs.findLibrary("androidx.lifecycle.viewModelCompose").get())
45+
"implementation"(libs.findLibrary("androidx.navigation.compose").get())
46+
"implementation"(libs.findLibrary("androidx.tracing.ktx").get())
47+
"implementation"(libs.findLibrary("kotlinx.serialization.json").get())
5148

52-
testImplementation(libs.findLibrary("androidx.navigation.testing").get())
53-
androidTestImplementation(libs.findLibrary("androidx.lifecycle.runtimeTesting").get())
49+
"testImplementation"(libs.findLibrary("androidx.navigation.testing").get())
50+
"androidTestImplementation"(libs.findLibrary("androidx.lifecycle.runtimeTesting").get())
5451
}
5552
}
5653
}

build-logic/convention/src/main/kotlin/AndroidLibraryConventionPlugin.kt

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,20 +16,16 @@
1616

1717
import com.android.build.api.variant.LibraryAndroidComponentsExtension
1818
import com.android.build.gradle.LibraryExtension
19-
import com.google.samples.apps.nowinandroid.androidTestImplementation
2019
import com.google.samples.apps.nowinandroid.configureFlavors
2120
import com.google.samples.apps.nowinandroid.configureGradleManagedDevices
2221
import com.google.samples.apps.nowinandroid.configureKotlinAndroid
2322
import com.google.samples.apps.nowinandroid.configurePrintApksTask
2423
import com.google.samples.apps.nowinandroid.disableUnnecessaryAndroidTests
25-
import com.google.samples.apps.nowinandroid.implementation
2624
import com.google.samples.apps.nowinandroid.libs
27-
import com.google.samples.apps.nowinandroid.testImplementation
2825
import org.gradle.api.Plugin
2926
import org.gradle.api.Project
3027
import org.gradle.kotlin.dsl.configure
3128
import org.gradle.kotlin.dsl.dependencies
32-
import org.gradle.kotlin.dsl.kotlin
3329

3430
class AndroidLibraryConventionPlugin : Plugin<Project> {
3531
override fun apply(target: Project) {
@@ -56,10 +52,10 @@ class AndroidLibraryConventionPlugin : Plugin<Project> {
5652
disableUnnecessaryAndroidTests(target)
5753
}
5854
dependencies {
59-
androidTestImplementation(libs.findLibrary("kotlin.test").get())
60-
testImplementation(libs.findLibrary("kotlin.test").get())
55+
"androidTestImplementation"(libs.findLibrary("kotlin.test").get())
56+
"testImplementation"(libs.findLibrary("kotlin.test").get())
6157

62-
implementation(libs.findLibrary("androidx.tracing.ktx").get())
58+
"implementation"(libs.findLibrary("androidx.tracing.ktx").get())
6359
}
6460
}
6561
}

build-logic/convention/src/main/kotlin/AndroidRoomConventionPlugin.kt

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616

1717
import androidx.room.gradle.RoomExtension
1818
import com.google.devtools.ksp.gradle.KspExtension
19-
import com.google.samples.apps.nowinandroid.implementation
20-
import com.google.samples.apps.nowinandroid.ksp
2119
import com.google.samples.apps.nowinandroid.libs
2220
import org.gradle.api.Plugin
2321
import org.gradle.api.Project
@@ -43,9 +41,9 @@ class AndroidRoomConventionPlugin : Plugin<Project> {
4341
}
4442

4543
dependencies {
46-
implementation(libs.findLibrary("room.runtime").get())
47-
implementation(libs.findLibrary("room.ktx").get())
48-
ksp(libs.findLibrary("room.compiler").get())
44+
"implementation"(libs.findLibrary("room.runtime").get())
45+
"implementation"(libs.findLibrary("room.ktx").get())
46+
"ksp"(libs.findLibrary("room.compiler").get())
4947
}
5048
}
5149
}

build-logic/convention/src/main/kotlin/HiltConventionPlugin.kt

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
*/
1616

1717
import com.android.build.gradle.api.AndroidBasePlugin
18-
import com.google.samples.apps.nowinandroid.implementation
19-
import com.google.samples.apps.nowinandroid.ksp
2018
import com.google.samples.apps.nowinandroid.libs
2119
import org.gradle.api.Plugin
2220
import org.gradle.api.Project
@@ -27,21 +25,21 @@ class HiltConventionPlugin : Plugin<Project> {
2725
with(target) {
2826
pluginManager.apply("com.google.devtools.ksp")
2927
dependencies {
30-
ksp(libs.findLibrary("hilt.compiler").get())
28+
"ksp"(libs.findLibrary("hilt.compiler").get())
3129
}
3230

3331
// Add support for Jvm Module, base on org.jetbrains.kotlin.jvm
3432
pluginManager.withPlugin("org.jetbrains.kotlin.jvm") {
3533
dependencies {
36-
implementation(libs.findLibrary("hilt.core").get())
34+
"implementation"(libs.findLibrary("hilt.core").get())
3735
}
3836
}
3937

4038
/** Add support for Android modules, based on [AndroidBasePlugin] */
4139
pluginManager.withPlugin("com.android.base") {
4240
pluginManager.apply("dagger.hilt.android.plugin")
4341
dependencies {
44-
implementation(libs.findLibrary("hilt.android").get())
42+
"implementation"(libs.findLibrary("hilt.android").get())
4543
}
4644
}
4745
}

build-logic/convention/src/main/kotlin/JvmLibraryConventionPlugin.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,9 @@
1616

1717
import com.google.samples.apps.nowinandroid.configureKotlinJvm
1818
import com.google.samples.apps.nowinandroid.libs
19-
import com.google.samples.apps.nowinandroid.testImplementation
2019
import org.gradle.api.Plugin
2120
import org.gradle.api.Project
2221
import org.gradle.kotlin.dsl.dependencies
23-
import org.gradle.kotlin.dsl.kotlin
2422

2523
class JvmLibraryConventionPlugin : Plugin<Project> {
2624
override fun apply(target: Project) {
@@ -31,7 +29,7 @@ class JvmLibraryConventionPlugin : Plugin<Project> {
3129
}
3230
configureKotlinJvm()
3331
dependencies {
34-
testImplementation(libs.findLibrary("kotlin.test").get())
32+
"testImplementation"(libs.findLibrary("kotlin.test").get())
3533
}
3634
}
3735
}

build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/AndroidCompose.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@ internal fun Project.configureAndroidCompose(
3737

3838
dependencies {
3939
val bom = libs.findLibrary("androidx-compose-bom").get()
40-
implementation(platform(bom))
41-
androidTestImplementation(platform(bom))
42-
implementation(libs.findLibrary("androidx-compose-ui-tooling-preview").get())
43-
debugImplementation(libs.findLibrary("androidx-compose-ui-tooling").get())
40+
"implementation"(platform(bom))
41+
"androidTestImplementation"(platform(bom))
42+
"implementation"(libs.findLibrary("androidx-compose-ui-tooling-preview").get())
43+
"debugImplementation"(libs.findLibrary("androidx-compose-ui-tooling").get())
4444
}
4545

4646
testOptions {

build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/KotlinAndroid.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ internal fun Project.configureKotlinAndroid(
5454
configureKotlin<KotlinAndroidProjectExtension>()
5555

5656
dependencies {
57-
coreLibraryDesugaring(libs.findLibrary("android.desugarJdkLibs").get())
57+
"coreLibraryDesugaring"(libs.findLibrary("android.desugarJdkLibs").get())
5858
}
5959
}
6060

0 commit comments

Comments
 (0)