Skip to content

Commit d549ca6

Browse files
Apply suggestions from code review
Co-authored-by: Simon Marquis <[email protected]>
1 parent ca8b22e commit d549ca6

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,8 @@ Run the following command to get and analyse compose compiler metrics:
159159
./gradlew assembleRelease -PenableComposeCompilerMetrics=true -PenableComposeCompilerReports=true
160160
```
161161

162-
The reports files will be added to build/compose-reports in root folder. The metrics files will also be
163-
added to build/compose-metrics in root folder.
162+
The reports files will be added to [build/compose-reports](build/compose-reports). The metrics files will also be
163+
added to [build/compose-metrics](build/compose-metrics).
164164

165165
For more information on Compose compiler metrics, see [this blog post](https://medium.com/androiddevelopers/jetpack-compose-stability-explained-79c10db270c8).
166166

build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/AndroidCompose.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ private fun Project.buildComposeMetricsParameters(): List<String> {
6161
val enableMetricsProvider = project.providers.gradleProperty("enableComposeCompilerMetrics")
6262
val enableMetrics = (enableMetricsProvider.orNull == "true")
6363
if (enableMetrics) {
64-
val metricsFolder = File(project.rootProject.buildDir, "compose-metrics")
64+
val metricsFolder = rootProject.buildDir.resolve("compose-metrics")
6565
metricParameters.add("-P")
6666
metricParameters.add(
6767
"plugin:androidx.compose.compiler.plugins.kotlin:metricsDestination=" + metricsFolder.absolutePath
@@ -71,7 +71,7 @@ private fun Project.buildComposeMetricsParameters(): List<String> {
7171
val enableReportsProvider = project.providers.gradleProperty("enableComposeCompilerReports")
7272
val enableReports = (enableReportsProvider.orNull == "true")
7373
if (enableReports) {
74-
val reportsFolder = File(project.rootProject.buildDir, "compose-reports")
74+
val reportsFolder = rootProject.buildDir.resolve("compose-reports")
7575
metricParameters.add("-P")
7676
metricParameters.add(
7777
"plugin:androidx.compose.compiler.plugins.kotlin:reportsDestination=" + reportsFolder.absolutePath

0 commit comments

Comments
 (0)