Skip to content

Commit e846078

Browse files
authored
Merge pull request #1955 from liutikas/osslicenses
Clean up loading of oss-licenses-plugin
2 parents a59cd20 + c53ceff commit e846078

File tree

3 files changed

+4
-28
lines changed

3 files changed

+4
-28
lines changed

app/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ plugins {
2222
alias(libs.plugins.nowinandroid.android.application.jacoco)
2323
alias(libs.plugins.nowinandroid.android.application.firebase)
2424
alias(libs.plugins.nowinandroid.hilt)
25-
id("com.google.android.gms.oss-licenses-plugin")
25+
alias(libs.plugins.google.osslicenses)
2626
alias(libs.plugins.baselineprofile)
2727
alias(libs.plugins.roborazzi)
2828
alias(libs.plugins.kotlin.serialization)

build.gradle.kts

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -14,28 +14,6 @@
1414
* limitations under the License.
1515
*/
1616

17-
buildscript {
18-
repositories {
19-
google {
20-
content {
21-
includeGroupByRegex("com\\.android.*")
22-
includeGroupByRegex("com\\.google.*")
23-
includeGroupByRegex("androidx.*")
24-
}
25-
}
26-
mavenCentral()
27-
28-
// This is used only for internal Google builds.
29-
maven { url = uri("../nowinandroid-prebuilts/m2repository") }
30-
}
31-
dependencies {
32-
classpath(libs.google.oss.licenses.plugin) {
33-
exclude(group = "com.google.protobuf")
34-
}
35-
}
36-
37-
}
38-
3917
/*
4018
* By listing all the plugins used throughout all subprojects in the root project build script, it
4119
* ensures that the build script classpath remains the same for all projects. This avoids potential
@@ -58,7 +36,7 @@ plugins {
5836
alias(libs.plugins.hilt) apply false
5937
alias(libs.plugins.ksp) apply false
6038
alias(libs.plugins.roborazzi) apply false
61-
alias(libs.plugins.secrets) apply false
39+
alias(libs.plugins.google.osslicenses) apply false
6240
alias(libs.plugins.room) apply false
6341
alias(libs.plugins.module.graph) apply true // Plugin applied to allow module graph generation
6442
}

gradle/libs.versions.toml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ firebaseCrashlyticsPlugin = "3.0.6"
3737
firebasePerfPlugin = "2.0.1"
3838
gmsPlugin = "4.4.2"
3939
googleOss = "17.1.0"
40-
googleOssPlugin = "0.10.7"
40+
googleOssPlugin = "0.10.8"
4141
hilt = "2.56"
4242
hiltExt = "1.2.0"
4343
jacoco = "0.8.12"
@@ -56,7 +56,6 @@ retrofitKotlinxSerializationJson = "1.0.0"
5656
robolectric = "4.14.1"
5757
roborazzi = "1.39.0"
5858
room = "2.7.2"
59-
secrets = "2.0.1"
6059
truth = "1.4.4"
6160
turbine = "1.2.0"
6261

@@ -119,7 +118,6 @@ firebase-cloud-messaging = { group = "com.google.firebase", name = "firebase-mes
119118
firebase-crashlytics = { group = "com.google.firebase", name = "firebase-crashlytics" }
120119
firebase-performance = { group = "com.google.firebase", name = "firebase-perf" }
121120
google-oss-licenses = { group = "com.google.android.gms", name = "play-services-oss-licenses", version.ref = "googleOss" }
122-
google-oss-licenses-plugin = { group = "com.google.android.gms", name = "oss-licenses-plugin", version.ref = "googleOssPlugin" }
123121
hilt-android = { group = "com.google.dagger", name = "hilt-android", version.ref = "hilt" }
124122
hilt-android-testing = { group = "com.google.dagger", name = "hilt-android-testing", version.ref = "hilt" }
125123
hilt-compiler = { group = "com.google.dagger", name = "hilt-compiler", version.ref = "hilt" }
@@ -178,10 +176,10 @@ kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" }
178176
kotlin-serialization = { id = "org.jetbrains.kotlin.plugin.serialization", version.ref = "kotlin" }
179177
ksp = { id = "com.google.devtools.ksp", version.ref = "ksp" }
180178
module-graph = { id = "com.jraska.module.graph.assertion", version.ref = "moduleGraph" }
179+
google-osslicenses = { id = "com.google.android.gms.oss-licenses-plugin", version.ref = "googleOssPlugin" }
181180
protobuf = { id = "com.google.protobuf", version.ref = "protobufPlugin" }
182181
roborazzi = { id = "io.github.takahirom.roborazzi", version.ref = "roborazzi" }
183182
room = { id = "androidx.room", version.ref = "room" }
184-
secrets = { id = "com.google.android.libraries.mapsplatform.secrets-gradle-plugin", version.ref = "secrets" }
185183

186184
# Plugins defined by this project
187185
nowinandroid-android-application = { id = "nowinandroid.android.application" }

0 commit comments

Comments
 (0)