Skip to content

Commit f0731b6

Browse files
committed
Use sdkComponents.aapt2 API for aapt2 path
1 parent e8010ce commit f0731b6

File tree

2 files changed

+3
-14
lines changed

2 files changed

+3
-14
lines changed

build-logic/convention/src/main/kotlin/AndroidApplicationConventionPlugin.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
import com.android.build.api.dsl.ApplicationExtension
1818
import com.android.build.api.variant.ApplicationAndroidComponentsExtension
19-
import com.android.build.gradle.BaseExtension
2019
import com.google.samples.apps.nowinandroid.configureBadgingTasks
2120
import com.google.samples.apps.nowinandroid.configureGradleManagedDevices
2221
import com.google.samples.apps.nowinandroid.configureKotlinAndroid
@@ -25,7 +24,6 @@ import org.gradle.api.Plugin
2524
import org.gradle.api.Project
2625
import org.gradle.kotlin.dsl.apply
2726
import org.gradle.kotlin.dsl.configure
28-
import org.gradle.kotlin.dsl.getByType
2927

3028
class AndroidApplicationConventionPlugin : Plugin<Project> {
3129
override fun apply(target: Project) {
@@ -44,7 +42,7 @@ class AndroidApplicationConventionPlugin : Plugin<Project> {
4442
}
4543
extensions.configure<ApplicationAndroidComponentsExtension> {
4644
configurePrintApksTask(this)
47-
configureBadgingTasks(extensions.getByType<BaseExtension>(), this)
45+
configureBadgingTasks(this)
4846
}
4947
}
5048
}

build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/Badging.kt

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,8 @@
1616

1717
package com.google.samples.apps.nowinandroid
1818

19-
import com.android.SdkConstants
2019
import com.android.build.api.artifact.SingleArtifact
2120
import com.android.build.api.variant.ApplicationAndroidComponentsExtension
22-
import com.android.build.gradle.BaseExtension
2321
import com.google.common.truth.Truth.assertWithMessage
2422
import org.gradle.api.DefaultTask
2523
import org.gradle.api.Project
@@ -110,7 +108,6 @@ private fun String.capitalized() = replaceFirstChar {
110108
}
111109

112110
fun Project.configureBadgingTasks(
113-
baseExtension: BaseExtension,
114111
componentsExtension: ApplicationAndroidComponentsExtension,
115112
) {
116113
// Registers a callback to be called, when a new variant is configured
@@ -122,14 +119,8 @@ fun Project.configureBadgingTasks(
122119
tasks.register<GenerateBadgingTask>(generateBadgingTaskName) {
123120
apk = variant.artifacts.get(SingleArtifact.APK_FROM_BUNDLE)
124121
aapt2Executable.set(
125-
// TODO: Replace with `sdkComponents.aapt2` when it's available in AGP
126-
// https://issuetracker.google.com/issues/376815836
127-
componentsExtension.sdkComponents.sdkDirectory.map { directory ->
128-
directory.file(
129-
"${SdkConstants.FD_BUILD_TOOLS}/" +
130-
"${baseExtension.buildToolsVersion}/" +
131-
SdkConstants.FN_AAPT2,
132-
)
122+
componentsExtension.sdkComponents.aapt2.flatMap { aapt2 ->
123+
aapt2.executable
133124
}
134125
)
135126
badging = project.layout.buildDirectory.file(

0 commit comments

Comments
 (0)