Moving Android instrumented tests to JVM unit tests?

[SimonMarquis]

Since the recent move to JVM screenshots testing with Roborazzi #876 and the flakiness/duration (from 35m up to 1h) of the Android instrumented tests, what are your thoughts on moving most (if not all) of the androidTest/ tests to /test when possible?

Here is a good example of such change, since ThemeTest.kt does not actually need to run on a physical/virtual device:

• Move Android instrumented test ThemeTest to unit test #1048

Here is the list of all instrumented tests:

• :app
  • app/src/androidTest/kotlin/com/google/samples/apps/nowinandroid/ui/NavigationTest.kt
  • app/src/androidTest/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppStateTest.kt
• :core:database
  • core/database/src/androidTest/kotlin/com/google/samples/apps/nowinandroid/core/database/dao/NewsResourceDaoTest.kt
• :core:designsystem
  • core/designsystem/src/androidTest/kotlin/com/google/samples/apps/nowinandroid/core/designsystem/ThemeTest.kt
• :core:ui
  • core/ui/src/androidTest/kotlin/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardTest.kt
• :feature:bookmarks
  • feature/bookmarks/src/androidTest/kotlin/com/google/samples/apps/nowinandroid/feature/bookmarks/BookmarksScreenTest.kt
• :feature:foryou
  • feature/foryou/src/androidTest/kotlin/com/google/samples/apps/nowinandroid/feature/foryou/ForYouScreenTest.kt
• :feature:interests
  • feature/interests/src/androidTest/kotlin/com/google/samples/apps/nowinandroid/interests/InterestsScreenTest.kt
• :feature:search
  • feature/search/src/androidTest/kotlin/com/google/samples/apps/nowinandroid/feature/search/SearchScreenTest.kt
• :feature:settings
  • feature/settings/src/androidTest/kotlin/com/google/samples/apps/nowinandroid/feature/settings/SettingsDialogTest.kt
• :feature:topic
  • feature/topic/src/androidTest/kotlin/com/google/samples/apps/nowinandroid/feature/topic/TopicScreenTest.kt
• :sync:work
  • sync/work/src/androidTest/kotlin/com/google/samples/apps/nowinandroid/sync/workers/SyncWorkerTest.kt