Why does Now in Android mix pluginManager.apply(...) and apply(...) when convention plugins?

[minjun011026]

I was studying the convention plugin Kotlin files under the build-logic directory in the Now in Android project. While reading the code, I noticed that both of the following styles are used to apply Gradle plugins:

class AndroidApplicationComposeConventionPlugin : Plugin<Project> {
    override fun apply(target: Project) {
        with(target) {
            apply(plugin = "com.android.application")
            apply(plugin = "org.jetbrains.kotlin.plugin.compose")

            val extension = extensions.getByType<ApplicationExtension>()
            configureAndroidCompose(extension)
        }
    }

}

class AndroidApplicationJacocoConventionPlugin : Plugin<Project> {
    override fun apply(target: Project) {
        with(target) {
            pluginManager.apply("jacoco")
            val androidExtension = extensions.getByType<ApplicationExtension>()

            androidExtension.buildTypes.configureEach {
                enableAndroidTestCoverage = true
                enableUnitTestCoverage = true
            }

            configureJacoco(extensions.getByType<ApplicationAndroidComponentsExtension>())
        }
    }
}

From what I understand, apply(...) is a Kotlin extension on PluginAware that internally delegates to pluginManager.apply(...). However, seeing these two different styles mixed within the same convention plugin files raised some questions.

Is there a specific reason or benefit to mixing these two approaches? Wouldn’t it be clearer and more consistent to pick one style (for example, always using ₩pluginManager.apply(...)₩) throughout the build-logic convention plugins?

I’d appreciate any insight into why the project chooses to use both styles.

Thanks in advance!

[SimonMarquis]

There is probably no good reason, you are more than welcome to draft a PR to unify these usages 👍

[minjun011026]

Thanks for the quick response!

Got it — I’ll go ahead and prepare a PR!
Update: I just realized this change has already been applied — my fork was a bit outdated, so I hadn’t noticed it earlier. Sorry for the confusion!