Skip to content

Commit 30ed522

Browse files
authored
Resolve warnings in the Wakelock code snippets (#615)
* Resolve warnings in the Wakelock code snippets I was getting code warnings in Android Studio, made some minor changes to resolve them: * used WakeLock.acquire(timeout) instead of acquire() * removed the redundant qualifier for POWER_SERVICE Once this PR is approved, I'll set up a corresponding docs CL to update the description to explain the acquire() parameter. * Apply Spotless * Per Alice's suggestion, used constant casing for the wakelock timeout (wlTimeout -> WAKELOCK_TIMEOUT)
1 parent 3d5181b commit 30ed522

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

misc/src/main/java/com/example/snippets/backgroundwork/WakeLockSnippetsJava.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
public class WakeLockSnippetsJava extends Activity {
1111

1212
PowerManager.WakeLock wakeLock;
13+
final long WAKELOCK_TIMEOUT = 10*60*1000L; // 10 minutes
1314

1415
@Override
1516
protected void onCreate(@Nullable Bundle savedInstanceState) {
@@ -18,7 +19,7 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
1819
PowerManager powerManager = (PowerManager) getSystemService(POWER_SERVICE);
1920
PowerManager.WakeLock wakeLock =
2021
powerManager.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK, "MyClassName::MyWakelockTag");
21-
wakeLock.acquire();
22+
wakeLock.acquire(WAKELOCK_TIMEOUT);
2223
// [END android_backgroundwork_wakelock_create_java]
2324

2425
super.onCreate(savedInstanceState);
@@ -28,7 +29,7 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
2829
// [START android_backgroundwork_wakelock_release_java]
2930
void doSomethingAndRelease() throws MyException {
3031
try {
31-
wakeLock.acquire();
32+
wakeLock.acquire(WAKELOCK_TIMEOUT);
3233
doTheWork();
3334
} finally {
3435
wakeLock.release();

misc/src/main/java/com/example/snippets/backgroundwork/WakeLockSnippetsKotlin.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,19 @@
1717
package com.example.snippets.backgroundwork
1818

1919
import android.app.Activity
20-
import android.content.Context
2120
import android.os.Bundle
2221
import android.os.PowerManager
2322

2423
// Snippets for doc page go here
2524
@Suppress("unused_parameter")
2625
class WakeLockSnippetsKotlin : Activity() {
2726

27+
val WAKELOCK_TIMEOUT = 10 * 60 * 1000L // 10 minutes
2828
// [START android_backgroundwork_wakelock_create_kotlin]
2929
val wakeLock: PowerManager.WakeLock =
30-
(getSystemService(Context.POWER_SERVICE) as PowerManager).run {
30+
(getSystemService(POWER_SERVICE) as PowerManager).run {
3131
newWakeLock(PowerManager.PARTIAL_WAKE_LOCK, "MyClassName::MyWakelockTag").apply {
32-
acquire()
32+
acquire(WAKELOCK_TIMEOUT)
3333
}
3434
}
3535
// [END android_backgroundwork_wakelock_create_kotlin]
@@ -44,7 +44,7 @@ class WakeLockSnippetsKotlin : Activity() {
4444
fun doSomethingAndRelease() {
4545
wakeLock.apply {
4646
try {
47-
acquire()
47+
acquire(WAKELOCK_TIMEOUT)
4848
doTheWork()
4949
} finally {
5050
release()

0 commit comments

Comments
 (0)