Prevent redrawing twice and running timer when compositions =0 (#304)

mlykotom · web-flow · commit 5ca7f540426f · 2024-08-08T12:27:18.000+02:00
diff --git a/compose/recomposehighlighter/src/main/java/com/example/android/compose/recomposehighlighter/RecomposeHighlighter.kt b/compose/recomposehighlighter/src/main/java/com/example/android/compose/recomposehighlighter/RecomposeHighlighter.kt
@@ -73,7 +73,7 @@ private class RecomposeHighlighterModifier : Modifier.Node(), DrawModifierNode {
     private var totalCompositions: Long = 0
         set(value) {
             if (field == value) return
-            restartTimer()
+            if (value > 0) restartTimer()
             field = value
             invalidateDraw()
         }
@@ -103,7 +103,6 @@ private class RecomposeHighlighterModifier : Modifier.Node(), DrawModifierNode {
         timerJob = coroutineScope.launch {
             delay(3000)
             totalCompositions = 0
-            invalidateDraw()
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ private class RecomposeHighlighterModifier : Modifier.Node(), DrawModifierNode {`
`73`	`73`	`private var totalCompositions: Long = 0`
`74`	`74`	`set(value) {`
`75`	`75`	`if (field == value) return`
`76`		`- restartTimer()`
	`76`	`+ if (value > 0) restartTimer()`
`77`	`77`	`field = value`
`78`	`78`	`invalidateDraw()`
`79`	`79`	`}`
`@@ -103,7 +103,6 @@ private class RecomposeHighlighterModifier : Modifier.Node(), DrawModifierNode {`
`103`	`103`	`timerJob = coroutineScope.launch {`
`104`	`104`	`delay(3000)`
`105`	`105`	`totalCompositions = 0`
`106`		`- invalidateDraw()`
`107`	`106`	`}`
`108`	`107`	`}`
`109`	`108`