-
Notifications
You must be signed in to change notification settings - Fork 289
Migrate XR snippets to alpha04 #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Here is the summary of changes. You are about to add 7 region tags.
This comment is generated by snippet-bot.
|
xr/build.gradle.kts
Outdated
| exclude(module = "impress") | ||
| } | ||
|
|
||
| implementation("com.google.ar:impress:0.0.2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does impress get added as a transitive dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes:
./gradlew :xr:dependencies
...
| +--- androidx.xr.runtime:runtime:1.0.0-alpha04
| | +--- androidx.annotation:annotation:1.8.1 -> 1.9.1 (*)
| | +--- androidx.core:core:1.1.0 -> 1.13.1
...
| | +--- com.google.ar:impress:0.0.3
| | | \--- androidx.concurrent:concurrent-futures:1.2.0 (*)
vad710
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jankleinert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Migrate XR snippets to alpha04 release