Revised snippets for consistency.

[JonEckenrode]

Revised snippets for consistency and correctness.

[asolovay]

Did you try compiling this code? I just tried on my machine and I got an error:

/usr/local/google/home/asolovay/AndroidStudioProjects/snippets/misc/src/androidTest/java/com/example/snippets/DeviceCompatibilityModeTestJavaSnippets.java:37: error: cannot find symbol
                    assertFalse(isLetterboxed(activity));
                                ^
  symbol:   method isLetterboxed(DeviceCompatibilityModeTestJavaSnippets.MainActivity)
  location: class DeviceCompatibilityModeTestJavaSnippets

I think that's because isLetterboxed() is now an internal method in the new MainActivity class.

Just a reminder, the checks don't currently run against code in androidTest, so you can't count on Github to tell you the code compiles.

[JonEckenrode]

Thanks, Andrew, for finding this. Try it now. Builds locally.

[asolovay]

Thanks! Looks fine to me, the code compiles for me too. (I don't think I have privileges to approve a pull request here, but Alex can do that, I assume?)

Just checking -- this last commit is a change to the code in the marked region (the code that shows up on the DAC page). Do you need to change the other Java snippet to match? (the snippet where you show how to define isLetterboxed()?)

[JonEckenrode]

Not sure what you mean, Andrew, The class that defines is letterboxed() is a helper class. It's not a snippet that's pulled from GitHub. But that class is added by this PR. There was just a method before.

[asolovay]

What I mean is, in the latest commit, you've changed assertFalse(isLetterboxed(activity)); to assertFalse(activity.isLetterboxed(activity));. That line of code is shown on the dac page, it's in the android_device_compatibility_mode_assert_isLetterboxed_java region. So I just wanted to confirm that you don't need to make some other corresponding change to the android_device_compatibility_mode_isLetterboxed_java code snippet, which tells the reader how to define their isLetterboxed() method.

But since you have an SME reviewing this CL, I'll let the two of you work that out!

[JonEckenrode]

I see what you mean now. Good point. The android_device_compatibility_mode_isLetterboxed_java snippet is good as is. But that snippet is why the assert snippet uses AppCompatActivity. Thanks for your thoroughness.