ref: it compiles and runs

Author: android10

app/src/main/kotlin/com/fernandocejas/sample/core/platform/BaseActivity.kt

@@ -48,6 +48,8 @@ abstract class BaseActivity : AppCompatActivity() {
         super.onBackPressed()
     }
 
+    fun toolbar() = binding.toolBarContainer.toolbar
+
     fun fragmentContainer() = binding.fragmentContainer
     fun progressBar() = binding.toolBarContainer.progress
 

app/src/main/kotlin/com/fernandocejas/sample/core/platform/BaseFragment.kt

@@ -16,9 +16,7 @@
 package com.fernandocejas.sample.core.platform
 
 import android.os.Bundle
-import android.view.LayoutInflater
 import android.view.View
-import android.view.ViewGroup
 import androidx.annotation.StringRes
 import androidx.core.content.ContextCompat
 import androidx.fragment.app.Fragment
@@ -36,15 +34,6 @@ import dagger.hilt.android.AndroidEntryPoint
 @AndroidEntryPoint
 abstract class BaseFragment : Fragment() {
 
-    abstract fun layoutId(): Int
-
-    override fun onCreateView(
-        inflater: LayoutInflater,
-        container: ViewGroup?,
-        savedInstanceState: Bundle?
-    ): View =
-        inflater.inflate(layoutId(), container, false)
-
     open fun onBackPressed() {}
 
     internal fun firstTimeCreated(savedInstanceState: Bundle?) = savedInstanceState == null

app/src/main/kotlin/com/fernandocejas/sample/features/login/LoginFragment.kt

@@ -15,9 +15,6 @@
  */
 package com.fernandocejas.sample.features.login
 
-import com.fernandocejas.sample.R
 import com.fernandocejas.sample.core.platform.BaseFragment
 
-class LoginFragment : BaseFragment() {
-    override fun layoutId() = R.layout.fragment_login
-}
+class LoginFragment : BaseFragment()

app/src/main/kotlin/com/fernandocejas/sample/features/movies/MovieDetailsFragment.kt

@@ -16,19 +16,26 @@
 package com.fernandocejas.sample.features.movies
 
 import android.os.Bundle
+import android.view.LayoutInflater
 import android.view.View
+import android.view.ViewGroup
 import androidx.core.os.bundleOf
 import androidx.fragment.app.viewModels
 import com.fernandocejas.sample.R
 import com.fernandocejas.sample.core.exception.Failure
 import com.fernandocejas.sample.core.exception.Failure.NetworkConnection
 import com.fernandocejas.sample.core.exception.Failure.ServerError
-import com.fernandocejas.sample.core.extension.*
+import com.fernandocejas.sample.core.extension.close
+import com.fernandocejas.sample.core.extension.failure
+import com.fernandocejas.sample.core.extension.isVisible
+import com.fernandocejas.sample.core.extension.loadFromUrl
+import com.fernandocejas.sample.core.extension.loadUrlAndPostponeEnterTransition
+import com.fernandocejas.sample.core.extension.observe
+import com.fernandocejas.sample.core.platform.BaseActivity
 import com.fernandocejas.sample.core.platform.BaseFragment
+import com.fernandocejas.sample.databinding.FragmentMovieDetailsBinding
 import com.fernandocejas.sample.features.movies.MovieFailure.NonExistentMovie
 import dagger.hilt.android.AndroidEntryPoint
-import kotlinx.android.synthetic.main.fragment_movie_details.*
-import kotlinx.android.synthetic.main.toolbar.*
 import javax.inject.Inject
 
 @AndroidEntryPoint
@@ -47,7 +54,8 @@ class MovieDetailsFragment : BaseFragment() {
 
     private val movieDetailsViewModel by viewModels<MovieDetailsViewModel>()
 
-    override fun layoutId() = R.layout.fragment_movie_details
+    private var _binding: FragmentMovieDetailsBinding? = null
+    private val binding get() = _binding!!
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
@@ -59,41 +67,57 @@ class MovieDetailsFragment : BaseFragment() {
         }
     }
 
+    override fun onCreateView(
+        inflater: LayoutInflater,
+        container: ViewGroup?,
+        savedInstanceState: Bundle?
+    ): View {
+        _binding = FragmentMovieDetailsBinding.inflate(inflater, container, false)
+        return binding.root
+    }
+
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
         if (firstTimeCreated(savedInstanceState)) {
             movieDetailsViewModel.loadMovieDetails((arguments?.get(PARAM_MOVIE) as MovieView).id)
         } else {
-            movieDetailsAnimator.scaleUpView(moviePlay)
-            movieDetailsAnimator.cancelTransition(moviePoster)
-            moviePoster.loadFromUrl((requireArguments()[PARAM_MOVIE] as MovieView).poster)
+            movieDetailsAnimator.scaleUpView(binding.moviePlay)
+            movieDetailsAnimator.cancelTransition(binding.moviePoster)
+            binding.moviePoster.loadFromUrl((requireArguments()[PARAM_MOVIE] as MovieView).poster)
         }
     }
 
+    override fun onDestroyView() {
+        super.onDestroyView()
+        _binding = null
+    }
+
     override fun onBackPressed() {
-        movieDetailsAnimator.fadeInvisible(scrollView, movieDetails)
-        if (moviePlay.isVisible())
-            movieDetailsAnimator.scaleDownView(moviePlay)
+        movieDetailsAnimator.fadeInvisible(binding.scrollView, binding.movieDetails)
+        if (binding.moviePlay.isVisible())
+            movieDetailsAnimator.scaleDownView(binding.moviePlay)
         else
-            movieDetailsAnimator.cancelTransition(moviePoster)
+            movieDetailsAnimator.cancelTransition(binding.moviePoster)
     }
 
     private fun renderMovieDetails(movie: MovieDetailsView?) {
         movie?.let {
             with(movie) {
                 activity?.let {
-                    moviePoster.loadUrlAndPostponeEnterTransition(poster, it)
-                    it.toolbar.title = title
+                    binding.moviePoster.loadUrlAndPostponeEnterTransition(poster, it)
+                    (it as BaseActivity).toolbar().title = title
+                }
+                with(binding) {
+                    movieSummary.text = summary
+                    movieCast.text = cast
+                    movieDirector.text = director
+                    movieYear.text = year.toString()
+                    moviePlay.setOnClickListener { movieDetailsViewModel.playMovie(trailer) }
                 }
-                movieSummary.text = summary
-                movieCast.text = cast
-                movieDirector.text = director
-                movieYear.text = year.toString()
-                moviePlay.setOnClickListener { movieDetailsViewModel.playMovie(trailer) }
             }
         }
-        movieDetailsAnimator.fadeVisible(scrollView, movieDetails)
-        movieDetailsAnimator.scaleUpView(moviePlay)
+        movieDetailsAnimator.fadeVisible(binding.scrollView, binding.movieDetails)
+        movieDetailsAnimator.scaleUpView(binding.moviePlay)
     }
 
     private fun handleFailure(failure: Failure?) {

app/src/main/kotlin/com/fernandocejas/sample/features/movies/MoviesAdapter.kt

@@ -15,41 +15,45 @@
  */
 package com.fernandocejas.sample.features.movies
 
-import android.view.View
+import android.annotation.SuppressLint
+import android.view.LayoutInflater
 import android.view.ViewGroup
 import androidx.recyclerview.widget.RecyclerView
-import com.fernandocejas.sample.R
-import com.fernandocejas.sample.core.extension.inflate
 import com.fernandocejas.sample.core.extension.loadFromUrl
 import com.fernandocejas.sample.core.navigation.Navigator
-import kotlinx.android.synthetic.main.row_movie.view.*
+import com.fernandocejas.sample.databinding.RowMovieBinding
 import javax.inject.Inject
 import kotlin.properties.Delegates
 
+@SuppressLint("NotifyDataSetChanged")
 class MoviesAdapter
 @Inject constructor() : RecyclerView.Adapter<MoviesAdapter.ViewHolder>() {
 
     internal var collection: List<MovieView> by Delegates.observable(emptyList()) { _, _, _ ->
+        //TODO: go for a more efficient solution
         notifyDataSetChanged()
     }
 
     internal var clickListener: (MovieView, Navigator.Extras) -> Unit = { _, _ -> }
 
-    override fun onCreateViewHolder(parent: ViewGroup, viewType: Int) =
-        ViewHolder(parent.inflate(R.layout.row_movie))
+    override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): ViewHolder {
+        val rowMovieBinding = RowMovieBinding.inflate(LayoutInflater.from(parent.context), parent, false)
+        return ViewHolder(rowMovieBinding)
+    }
 
-    override fun onBindViewHolder(viewHolder: ViewHolder, position: Int) =
+    override fun onBindViewHolder(viewHolder: ViewHolder, position: Int) {
         viewHolder.bind(collection[position], clickListener)
+    }
 
     override fun getItemCount() = collection.size
 
-    class ViewHolder(itemView: View) : RecyclerView.ViewHolder(itemView) {
+    class ViewHolder(private val rowMovieBinding: RowMovieBinding) : RecyclerView.ViewHolder(rowMovieBinding.root) {
         fun bind(movieView: MovieView, clickListener: (MovieView, Navigator.Extras) -> Unit) {
-            itemView.moviePoster.loadFromUrl(movieView.poster)
+            rowMovieBinding.moviePoster.loadFromUrl(movieView.poster)
             itemView.setOnClickListener {
                 clickListener(
                     movieView,
-                    Navigator.Extras(itemView.moviePoster)
+                    Navigator.Extras(rowMovieBinding.moviePoster)
                 )
             }
         }

app/src/main/kotlin/com/fernandocejas/sample/features/movies/MoviesFragment.kt

@@ -16,7 +16,9 @@
 package com.fernandocejas.sample.features.movies
 
 import android.os.Bundle
+import android.view.LayoutInflater
 import android.view.View
+import android.view.ViewGroup
 import androidx.annotation.StringRes
 import androidx.fragment.app.viewModels
 import androidx.recyclerview.widget.StaggeredGridLayoutManager
@@ -30,6 +32,7 @@ import com.fernandocejas.sample.core.extension.observe
 import com.fernandocejas.sample.core.extension.visible
 import com.fernandocejas.sample.core.navigation.Navigator
 import com.fernandocejas.sample.core.platform.BaseFragment
+import com.fernandocejas.sample.databinding.FragmentMoviesBinding
 import com.fernandocejas.sample.features.movies.MovieFailure.ListNotAvailable
 import dagger.hilt.android.AndroidEntryPoint
 import javax.inject.Inject
@@ -44,7 +47,8 @@ class MoviesFragment : BaseFragment() {
 
     private val moviesViewModel: MoviesViewModel by viewModels()
 
-    override fun layoutId() = R.layout.fragment_movies
+    private var _binding: FragmentMoviesBinding? = null
+    private val binding get() = _binding!!
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
@@ -55,24 +59,37 @@ class MoviesFragment : BaseFragment() {
         }
     }
 
+    override fun onCreateView(
+        inflater: LayoutInflater,
+        container: ViewGroup?,
+        savedInstanceState: Bundle?
+    ): View {
+        _binding = FragmentMoviesBinding.inflate(inflater, container, false)
+        return binding.root
+    }
+
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
         initializeView()
         loadMoviesList()
     }
 
+    override fun onDestroyView() {
+        super.onDestroyView()
+        _binding = null
+    }
 
     private fun initializeView() {
-        movieList.layoutManager = StaggeredGridLayoutManager(3, StaggeredGridLayoutManager.VERTICAL)
-        movieList.adapter = moviesAdapter
+        binding.movieList.layoutManager = StaggeredGridLayoutManager(3, StaggeredGridLayoutManager.VERTICAL)
+        binding.movieList.adapter = moviesAdapter
         moviesAdapter.clickListener = { movie, navigationExtras ->
             navigator.showMovieDetails(requireActivity(), movie, navigationExtras)
         }
     }
 
     private fun loadMoviesList() {
-        emptyView.invisible()
-        movieList.visible()
+        binding.emptyView.invisible()
+        binding.movieList.visible()
         showProgress()
         moviesViewModel.loadMovies()
     }
@@ -92,8 +109,8 @@ class MoviesFragment : BaseFragment() {
     }
 
     private fun renderFailure(@StringRes message: Int) {
-        movieList.invisible()
-        emptyView.visible()
+        binding.movieList.invisible()
+        binding.emptyView.visible()
         hideProgress()
         notifyWithAction(message, R.string.action_refresh, ::loadMoviesList)
     }