Skip to content

Commit 2ce8e4b

Browse files
authored
Add stack trace for test issues (#78)
* Add stack trace for test issues * updating test
1 parent 658806b commit 2ce8e4b

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestRunnerService.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,6 +375,10 @@ interface TestRunnerService {
375375
/**
376376
* Type of issue
377377
*/
378-
val type: String?
378+
val type: String?,
379+
/**
380+
* Stack trace message
381+
*/
382+
val stackTrace: String?,
379383
)
380384
}

AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestRunnerServiceImpl.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,8 @@ internal class TestRunnerServiceImpl internal constructor(
288288
TestRunnerService.TestIssue(
289289
errorMessage = testIssue.errorMessage ?: "error message not set",
290290
severity = testIssue.severity?.name ?: "unspecifiedSeverity",
291-
type = testIssue.type?.name
291+
type = testIssue.type?.name,
292+
stackTrace = testIssue.stackTrace?.exception
292293
)
293294
} ?: emptyList()
294295
)

AndroidXCI/lib/src/test/kotlin/dev/androidx/ci/testRunner/TestRunnerServiceImplTest.kt

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import dev.androidx.ci.generated.ftl.TestSpecification
1616
import dev.androidx.ci.generated.ftl.ToolResultsExecution
1717
import dev.androidx.ci.generated.ftl.UniformSharding
1818
import dev.androidx.ci.generated.testResults.FileReference
19+
import dev.androidx.ci.generated.testResults.StackTrace
1920
import dev.androidx.ci.generated.testResults.Step
2021
import dev.androidx.ci.generated.testResults.TestCaseReference
2122
import dev.androidx.ci.generated.testResults.TestExecutionStep
@@ -1446,7 +1447,8 @@ class TestRunnerServiceImplTest {
14461447
testIssues = listOf(
14471448
TestIssue(
14481449
errorMessage = "test module error",
1449-
severity = TestIssue.Severity.severe
1450+
severity = TestIssue.Severity.severe,
1451+
stackTrace = StackTrace(exception = "stack trace")
14501452
)
14511453
)
14521454
)
@@ -1462,6 +1464,11 @@ class TestRunnerServiceImplTest {
14621464
).isEqualTo(
14631465
"test module error"
14641466
)
1467+
assertThat(
1468+
testIssues[stepId]?.first()?.stackTrace
1469+
).isEqualTo(
1470+
"stack trace"
1471+
)
14651472
}
14661473

14671474
private fun TestRunnerService.ResultFileResource.readFully() = openInputStream().use {

0 commit comments

Comments
 (0)