]fail action only if there are failed tests (#67)

* fail action only if there are failed tests

This Cl changes CLIMain to only fail if there are known failres and
ignore skips.

Also, the prior CL missed passing the environment variable for this parameter,
it is fixed in this CL.

Finally, i've updated GCP credentials rule to accept application credentials,
which is very handy for local testing

* Update AndroidXCI/cli/src/main/kotlin/dev/androidx/ci/cli/Main.kt

Co-authored-by: Dustin Lam <[email protected]>

* ktformat

---------

Co-authored-by: Dustin Lam <[email protected]>

Author: yigit

AndroidXCI/cli/src/main/kotlin/dev/androidx/ci/cli/Main.kt

@@ -17,6 +17,8 @@
 package dev.androidx.ci.cli
 
 import com.github.ajalt.clikt.core.CliktCommand
+import com.github.ajalt.clikt.parameters.options.convert
+import com.github.ajalt.clikt.parameters.options.default
 import com.github.ajalt.clikt.parameters.options.option
 import com.github.ajalt.clikt.parameters.options.required
 import com.github.ajalt.clikt.parameters.types.file
@@ -154,7 +156,14 @@ private class Cli : CliktCommand() {
             are run for a TestMatrix.
         """.trimIndent(),
         envvar = "ANDROIDX_IGNORE_EMPTY_TEST_MATRICES"
-    )
+    ).convert {
+        if (it.isNullOrBlank()) {
+            // default to true.
+            true
+        } else {
+            it.toBoolean()
+        }
+    }.default(true)
 
     override fun run() {
         logFile?.let(::configureLogger)
@@ -186,13 +195,13 @@ private class Cli : CliktCommand() {
                 bucketPath = gcpBucketPath,
                 useTestConfigFiles = useTestConfigFiles?.toBoolean() ?: false,
                 testSuiteTags = testSuiteTags?.split(',')?.map { it.trim() } ?: emptyList(),
-                ignoreEmptyTestMatrices = ignoreEmptyTestMatrices?.toBoolean() ?: true,
+                ignoreEmptyTestMatrices = ignoreEmptyTestMatrices,
             )
             testRunner.runTests()
         }
         println(result.toJson())
         flushLogs()
-        if (result.allTestsPassed) {
+        if (!result.hasFailedTest) {
             exitProcess(0)
         } else {
             println("================= FAILURE LOG =================")

AndroidXCI/lib/src/test/kotlin/dev/androidx/ci/util/GoogleCloudCredentialsRule.kt

@@ -16,6 +16,7 @@
 
 package dev.androidx.ci.util
 
+import com.google.auth.oauth2.GoogleCredentials
 import com.google.auth.oauth2.ServiceAccountCredentials
 import dev.androidx.ci.config.Config
 import org.junit.AssumptionViolatedException
@@ -30,14 +31,23 @@ internal class GoogleCloudCredentialsRule : TestRule {
     lateinit var gcpConfig: Config.Gcp
         private set
     private fun loadCredentials() {
-        val envValue = System.getenv("ANDROIDX_GCLOUD_CREDENTIALS")
-            ?: throw AssumptionViolatedException("skip test without credentials")
-        val credentials = ServiceAccountCredentials.fromStream(
-            envValue.byteInputStream(Charsets.UTF_8)
-        )
+        val appCredentialsProject = System.getenv("ANDROIDX_GCLOUD_APP_CREDENTIALS_PROJECT")
+        val (projectId, credentials) = if (appCredentialsProject != null) {
+            appCredentialsProject to GoogleCredentials.getApplicationDefault()
+        } else {
+            val credentialsParam = System.getenv("ANDROIDX_GCLOUD_CREDENTIALS")
+                ?: throw AssumptionViolatedException("skip test without credentials")
+            val credentials = ServiceAccountCredentials.fromStream(
+                credentialsParam.byteInputStream(Charsets.UTF_8)
+            )
+            credentials.projectId to credentials
+        }
+        if (credentials == null) {
+            throw AssumptionViolatedException("need to provide app credentials")
+        }
         gcpConfig = Config.Gcp(
             credentials = credentials,
-            projectId = credentials.projectId
+            projectId = projectId
         )
     }
 

action.yml

@@ -61,4 +61,5 @@ runs:
         ANDROIDX_BUCKET_NAME: ${{ inputs.gcp-bucket-name }}
         ANDROIDX_BUCKET_PATH: ${{ inputs.gcp-bucket-path }}
         ANDROIDX_USE_TEST_CONFIG_FILES: ${{ inputs.use-test-config-files }}
-        ANDROIDX_TEST_SUITE_TAGS: ${{ inputs.test-suite-tags }}
+        ANDROIDX_TEST_SUITE_TAGS: ${{ inputs.test-suite-tags }}
+        ANDROIDX_IGNORE_EMPTY_TEST_MATRICES: ${{ inputs.ignore-empty-test-matrices }}