Add stepId to the response of getTestMatrixTestIssues (#75)

* Add stepId to the response of getTestMatrixTestIssues

* linting

Author: rnakade

AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestRunnerService.kt

@@ -130,7 +130,7 @@ interface TestRunnerService {
      */
     suspend fun getTestMatrixTestIssues(
         testMatrix: TestMatrix
-    ): List<TestIssue>
+    ): Map<String, List<TestIssue>>
 
     companion object {
         /**

AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestRunnerServiceImpl.kt

@@ -26,7 +26,6 @@ import dev.androidx.ci.generated.ftl.ClientInfo
 import dev.androidx.ci.generated.ftl.ShardingOption
 import dev.androidx.ci.generated.ftl.TestEnvironmentCatalog
 import dev.androidx.ci.generated.ftl.TestMatrix
-import dev.androidx.ci.generated.testResults.TestIssue
 import dev.androidx.ci.testRunner.vo.DeviceSetup
 import dev.androidx.ci.testRunner.vo.RemoteApk
 import dev.androidx.ci.testRunner.vo.UploadedApk
@@ -281,19 +280,23 @@ internal class TestRunnerServiceImpl internal constructor(
         }
     }
 
-    override suspend fun getTestMatrixTestIssues(testMatrix: TestMatrix): List<TestRunnerService.TestIssue> {
+    override suspend fun getTestMatrixTestIssues(testMatrix: TestMatrix): Map<String, List<TestRunnerService.TestIssue>> {
         val steps = testExecutionStore.getTestExecutionSteps(testMatrix)
-        val testIssues = steps.flatMap {
-            it.testExecutionStep?.testIssues ?: emptyList()
-        }.map {
-            TestRunnerService.TestIssue(
-                errorMessage = it.errorMessage ?: "error message not set",
-                severity = it.severity?.name ?: "unspecifiedSeverity",
-                type = it.type?.name
-            )
+        return steps.associate {
+            (it.stepId ?: "invalidStepId") to (
+                (it.testExecutionStep?.testIssues)?.map { testIssue ->
+                    TestRunnerService.TestIssue(
+                        errorMessage = testIssue.errorMessage ?: "error message not set",
+                        severity = testIssue.severity?.name ?: "unspecifiedSeverity",
+                        type = testIssue.type?.name
+                    )
+                } ?: emptyList()
+                )
+        }.filter {
+            it.key != "invalidStepId"
+        }.filter {
+            it.value.isNotEmpty()
         }
-
-        return testIssues
     }
 
     suspend fun getTestMatrixResults(

AndroidXCI/lib/src/test/kotlin/dev/androidx/ci/testRunner/TestRunnerServiceImplTest.kt

@@ -1435,12 +1435,13 @@ class TestRunnerServiceImplTest {
             subject.getTestMatrixTestIssues(testMatrix)
         ).isEmpty()
 
+        val stepId = UUID.randomUUID().toString()
         fakeToolsResultApi.addStep(
             projectId = fakeBackend.firebaseProjectId,
             executionId = "test_executionId",
             historyId = "test_historyId",
             step = Step(
-                stepId = UUID.randomUUID().toString(),
+                stepId = stepId,
                 testExecutionStep = TestExecutionStep(
                     testIssues = listOf(
                         TestIssue(
@@ -1457,7 +1458,7 @@ class TestRunnerServiceImplTest {
         ).isNotEmpty()
 
         assertThat(
-            testIssues.first().errorMessage
+            testIssues[stepId]?.first()?.errorMessage
         ).isEqualTo(
             "test module error"
         )