ref: only save latest version if provided version is greater than current

Author: joemonem

contracts/os/andromeda-adodb/src/execute.rs

@@ -1,6 +1,6 @@
 use crate::state::{
     read_code_id, remove_code_id, save_action_fees, store_code_id, ACTION_FEES, ADO_TYPE,
-    LATEST_VERSION, PUBLISHER, UNPUBLISHED_CODE_IDS, UNPUBLISHED_VERSIONS,
+    PUBLISHER, UNPUBLISHED_CODE_IDS, UNPUBLISHED_VERSIONS,
 };
 
 use andromeda_std::ado_contract::ADOContract;
@@ -43,23 +43,13 @@ pub fn publish(
             msg: Some("ado_type can't be an empty string".to_string())
         }
     );
-    let current_ado_version = LATEST_VERSION.may_load(deps.storage, &ado_type)?;
+
     ensure!(
         semver::Version::parse(&version).is_ok(),
         ContractError::InvalidADOVersion {
             msg: Some("Provided version is not valid semver".to_string())
         }
     );
-    let new_version = semver::Version::parse(&version).unwrap();
-    if let Some(ado_version) = current_ado_version {
-        let current_version = semver::Version::parse(&ado_version.0).unwrap();
-        ensure!(
-            new_version != current_version,
-            ContractError::InvalidADOVersion {
-                msg: Some("Version must be different than the current version".to_string())
-            }
-        );
-    }
 
     let version = ADOVersion::from_type(ado_type).with_version(version);
     ensure!(

contracts/os/andromeda-adodb/src/state.rs

@@ -37,14 +37,29 @@ pub fn store_code_id(
         .ok()
         .ok_or(ContractError::InvalidADOVersion { msg: None })?;
     let prerelease = version.pre.parse::<String>().unwrap_or_default();
+
     if prerelease.is_empty() {
-        LATEST_VERSION
-            .save(
-                storage,
-                &ado_version.get_type(),
-                &(ado_version.get_version(), code_id),
-            )
-            .unwrap();
+        let current_ado_version = LATEST_VERSION.may_load(storage, &ado_version.get_type())?;
+        if let Some(current_ado_version) = current_ado_version {
+            let current_version = semver::Version::parse(&current_ado_version.0).unwrap();
+            if version > current_version {
+                LATEST_VERSION
+                    .save(
+                        storage,
+                        &ado_version.get_type(),
+                        &(ado_version.get_version(), code_id),
+                    )
+                    .unwrap();
+            }
+        } else {
+            LATEST_VERSION
+                .save(
+                    storage,
+                    &ado_version.get_type(),
+                    &(ado_version.get_version(), code_id),
+                )
+                .unwrap();
+        }
     }
     CODE_ID
         .save(storage, ado_version.as_str(), &code_id)