Skip to content

Commit 22a8d9d

Browse files
prudhvigodithiprudhvigodithi
authored
Intra segment support for single-value metric aggregations (opensearch-project#20503)
* intra segment support for query_string Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * update changelog Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Intra segment support for single-value metric aggregations Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * upstream fetch Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * update CHANGELOG.md Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Upstream fetch Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Add tests Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Add tests Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Fix tests Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Temp revert intra for cardinality agg Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Enable intra for cardinality agg Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * test: Add unit tests for intra-segment search support Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Fix commit issue Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Address github comments Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Address github comments Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Add wipeIndices to tests Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Update the IT tests Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Update the IT tests Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Fetch upstream Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Edge case bug with indexBulkWithSegments Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Address comments Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Address comments Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Upstream fetch, fix conflicts Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Upstream fetch, fix conflicts Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Upstream fetch Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Upstream fetch, fix conflicts Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> --------- Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
1 parent 1ab15af commit 22a8d9d

File tree

23 files changed

+553
-2
lines changed

23 files changed

+553
-2
lines changed

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
2020
- Added support of WarmerRefreshListener in NRTReplicationEngine to trigger warmer after replication on replica shards ([#20650](https://github.com/opensearch-project/OpenSearch/pull/20650))
2121
- WLM group custom search settings - groundwork and timeout ([#20536](https://github.com/opensearch-project/OpenSearch/issues/20536))
2222
- Expose JVM runtime metrics via telemetry framework ([#20844](https://github.com/opensearch-project/OpenSearch/pull/20844))
23+
- Add intra segment support for single-value metric aggregations ([#20503](https://github.com/opensearch-project/OpenSearch/pull/20503))
2324

2425
### Changed
2526
- Make telemetry `Tags` immutable ([#20788](https://github.com/opensearch-project/OpenSearch/pull/20788))

‎server/src/internalClusterTest/java/org/opensearch/search/aggregations/metrics/AvgIT.java‎

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,72 @@
1+
/*
2+
* SPDX-License-Identifier: Apache-2.0
3+
*
4+
* The OpenSearch Contributors require contributions made to
5+
* this file be licensed under the Apache-2.0 license or a
6+
* compatible open source license.
7+
*/
8+
9+
package org.opensearch.search.aggregations.metrics;
10+
11+
import com.carrotsearch.randomizedtesting.annotations.ParametersFactory;
12+
13+
import org.opensearch.action.index.IndexRequestBuilder;
14+
import org.opensearch.action.search.SearchResponse;
15+
import org.opensearch.common.settings.Settings;
16+
import org.opensearch.test.ParameterizedStaticSettingsOpenSearchIntegTestCase;
17+
18+
import java.util.ArrayList;
19+
import java.util.Arrays;
20+
import java.util.Collection;
21+
import java.util.List;
22+
23+
import static org.opensearch.search.SearchService.CLUSTER_CONCURRENT_SEGMENT_SEARCH_SETTING;
24+
import static org.opensearch.search.SearchService.CONCURRENT_SEGMENT_SEARCH_PARTITION_MIN_SEGMENT_SIZE;
25+
import static org.opensearch.search.SearchService.CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY;
26+
import static org.opensearch.search.aggregations.AggregationBuilders.avg;
27+
import static org.opensearch.test.hamcrest.OpenSearchAssertions.assertSearchResponse;
28+
import static org.hamcrest.Matchers.closeTo;
29+
import static org.hamcrest.Matchers.notNullValue;
30+
31+
/**
32+
* Integration tests for avg aggregation with concurrent segment search partition strategies.
33+
*/
34+
public class AvgIT extends ParameterizedStaticSettingsOpenSearchIntegTestCase {
35+
36+
public AvgIT(Settings staticSettings) {
37+
super(staticSettings);
38+
}
39+
40+
@ParametersFactory
41+
public static Collection<Object[]> parameters() {
42+
return Arrays.asList(
43+
new Object[] { Settings.builder().put(CLUSTER_CONCURRENT_SEGMENT_SEARCH_SETTING.getKey(), false).build() },
44+
new Object[] { Settings.builder().put(CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY.getKey(), "segment").build() },
45+
new Object[] { Settings.builder().put(CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY.getKey(), "force").build() },
46+
new Object[] {
47+
Settings.builder()
48+
.put(CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY.getKey(), "balanced")
49+
.put(CONCURRENT_SEGMENT_SEARCH_PARTITION_MIN_SEGMENT_SIZE.getKey(), 1000)
50+
.build() }
51+
);
52+
}
53+
54+
public void testAvgAggregation() throws Exception {
55+
createIndex("test_avg_agg", Settings.builder().put("index.number_of_shards", 2).put("index.number_of_replicas", 1).build());
56+
try {
57+
List<IndexRequestBuilder> builders = new ArrayList<>(5000);
58+
for (int i = 0; i < 5000; i++) {
59+
builders.add(client().prepareIndex("test_avg_agg").setSource("value", i + 1));
60+
}
61+
indexBulkWithSegments(builders, 2);
62+
indexRandomForConcurrentSearch("test_avg_agg");
63+
SearchResponse response = client().prepareSearch("test_avg_agg").addAggregation(avg("avg_agg").field("value")).get();
64+
assertSearchResponse(response);
65+
Avg avgAgg = response.getAggregations().get("avg_agg");
66+
assertThat(avgAgg, notNullValue());
67+
assertThat(avgAgg.getValue(), closeTo(2500.5, 0.1));
68+
} finally {
69+
internalCluster().wipeIndices("test_avg_agg");
70+
}
71+
}
72+
}

‎server/src/internalClusterTest/java/org/opensearch/search/aggregations/metrics/CardinalityIT.java‎

Lines changed: 31 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,12 @@
5050
import org.opensearch.test.OpenSearchIntegTestCase;
5151
import org.opensearch.test.ParameterizedStaticSettingsOpenSearchIntegTestCase;
5252

53+
import java.util.ArrayList;
5354
import java.util.Arrays;
5455
import java.util.Collection;
5556
import java.util.Collections;
5657
import java.util.HashMap;
58+
import java.util.List;
5759
import java.util.Map;
5860
import java.util.function.Function;
5961

@@ -62,6 +64,8 @@
6264
import static org.opensearch.index.query.QueryBuilders.matchAllQuery;
6365
import static org.opensearch.search.SearchService.CARDINALITY_AGGREGATION_PRUNING_THRESHOLD;
6466
import static org.opensearch.search.SearchService.CLUSTER_CONCURRENT_SEGMENT_SEARCH_SETTING;
67+
import static org.opensearch.search.SearchService.CONCURRENT_SEGMENT_SEARCH_PARTITION_MIN_SEGMENT_SIZE;
68+
import static org.opensearch.search.SearchService.CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY;
6569
import static org.opensearch.search.aggregations.AggregationBuilders.cardinality;
6670
import static org.opensearch.search.aggregations.AggregationBuilders.global;
6771
import static org.opensearch.search.aggregations.AggregationBuilders.terms;
@@ -82,7 +86,13 @@ public CardinalityIT(Settings staticSettings) {
8286
public static Collection<Object[]> parameters() {
8387
return Arrays.asList(
8488
new Object[] { Settings.builder().put(CLUSTER_CONCURRENT_SEGMENT_SEARCH_SETTING.getKey(), false).build() },
85-
new Object[] { Settings.builder().put(CLUSTER_CONCURRENT_SEGMENT_SEARCH_SETTING.getKey(), true).build() }
89+
new Object[] { Settings.builder().put(CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY.getKey(), "segment").build() },
90+
new Object[] { Settings.builder().put(CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY.getKey(), "force").build() },
91+
new Object[] {
92+
Settings.builder()
93+
.put(CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY.getKey(), "balanced")
94+
.put(CONCURRENT_SEGMENT_SEARCH_PARTITION_MIN_SEGMENT_SIZE.getKey(), 1000)
95+
.build() }
8696
);
8797
}
8898

@@ -666,4 +676,24 @@ public void testScriptCaching() throws Exception {
666676
);
667677
internalCluster().wipeIndices("cache_test_idx");
668678
}
679+
680+
public void testCardinalityWithIntraSegmentPartitioning() throws Exception {
681+
createIndex("test_cardinality_agg", Settings.builder().put("index.number_of_shards", 2).put("index.number_of_replicas", 1).build());
682+
try {
683+
List<IndexRequestBuilder> builders = new ArrayList<>(5000);
684+
for (int i = 0; i < 5000; i++) {
685+
builders.add(client().prepareIndex("test_cardinality_agg").setSource("category", i % 100));
686+
}
687+
indexBulkWithSegments(builders, 2);
688+
indexRandomForConcurrentSearch("test_cardinality_agg");
689+
SearchResponse response = client().prepareSearch("test_cardinality_agg")
690+
.addAggregation(cardinality("cardinality").field("category"))
691+
.get();
692+
Cardinality cardinalityAgg = response.getAggregations().get("cardinality");
693+
assertThat(cardinalityAgg, notNullValue());
694+
assertThat(cardinalityAgg.getValue(), equalTo(100L));
695+
} finally {
696+
internalCluster().wipeIndices("test_cardinality_agg");
697+
}
698+
}
669699
}

‎server/src/internalClusterTest/java/org/opensearch/search/aggregations/metrics/MaxIT.java‎

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,72 @@
1+
/*
2+
* SPDX-License-Identifier: Apache-2.0
3+
*
4+
* The OpenSearch Contributors require contributions made to
5+
* this file be licensed under the Apache-2.0 license or a
6+
* compatible open source license.
7+
*/
8+
9+
package org.opensearch.search.aggregations.metrics;
10+
11+
import com.carrotsearch.randomizedtesting.annotations.ParametersFactory;
12+
13+
import org.opensearch.action.index.IndexRequestBuilder;
14+
import org.opensearch.action.search.SearchResponse;
15+
import org.opensearch.common.settings.Settings;
16+
import org.opensearch.test.ParameterizedStaticSettingsOpenSearchIntegTestCase;
17+
18+
import java.util.ArrayList;
19+
import java.util.Arrays;
20+
import java.util.Collection;
21+
import java.util.List;
22+
23+
import static org.opensearch.search.SearchService.CLUSTER_CONCURRENT_SEGMENT_SEARCH_SETTING;
24+
import static org.opensearch.search.SearchService.CONCURRENT_SEGMENT_SEARCH_PARTITION_MIN_SEGMENT_SIZE;
25+
import static org.opensearch.search.SearchService.CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY;
26+
import static org.opensearch.search.aggregations.AggregationBuilders.max;
27+
import static org.opensearch.test.hamcrest.OpenSearchAssertions.assertSearchResponse;
28+
import static org.hamcrest.Matchers.closeTo;
29+
import static org.hamcrest.Matchers.notNullValue;
30+
31+
/**
32+
* Integration tests for max aggregation with concurrent segment search partition strategies.
33+
*/
34+
public class MaxIT extends ParameterizedStaticSettingsOpenSearchIntegTestCase {
35+
36+
public MaxIT(Settings staticSettings) {
37+
super(staticSettings);
38+
}
39+
40+
@ParametersFactory
41+
public static Collection<Object[]> parameters() {
42+
return Arrays.asList(
43+
new Object[] { Settings.builder().put(CLUSTER_CONCURRENT_SEGMENT_SEARCH_SETTING.getKey(), false).build() },
44+
new Object[] { Settings.builder().put(CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY.getKey(), "segment").build() },
45+
new Object[] { Settings.builder().put(CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY.getKey(), "force").build() },
46+
new Object[] {
47+
Settings.builder()
48+
.put(CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY.getKey(), "balanced")
49+
.put(CONCURRENT_SEGMENT_SEARCH_PARTITION_MIN_SEGMENT_SIZE.getKey(), 1000)
50+
.build() }
51+
);
52+
}
53+
54+
public void testMaxAggregation() throws Exception {
55+
createIndex("test_max_agg", Settings.builder().put("index.number_of_shards", 2).put("index.number_of_replicas", 1).build());
56+
try {
57+
List<IndexRequestBuilder> builders = new ArrayList<>(5000);
58+
for (int i = 0; i < 5000; i++) {
59+
builders.add(client().prepareIndex("test_max_agg").setSource("value", i + 1));
60+
}
61+
indexBulkWithSegments(builders, 2);
62+
indexRandomForConcurrentSearch("test_max_agg");
63+
SearchResponse response = client().prepareSearch("test_max_agg").addAggregation(max("max_agg").field("value")).get();
64+
assertSearchResponse(response);
65+
Max maxAgg = response.getAggregations().get("max_agg");
66+
assertThat(maxAgg, notNullValue());
67+
assertThat(maxAgg.getValue(), closeTo(5000.0, 0.1));
68+
} finally {
69+
internalCluster().wipeIndices("test_max_agg");
70+
}
71+
}
72+
}

‎server/src/internalClusterTest/java/org/opensearch/search/aggregations/metrics/MinIT.java‎

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,72 @@
1+
/*
2+
* SPDX-License-Identifier: Apache-2.0
3+
*
4+
* The OpenSearch Contributors require contributions made to
5+
* this file be licensed under the Apache-2.0 license or a
6+
* compatible open source license.
7+
*/
8+
9+
package org.opensearch.search.aggregations.metrics;
10+
11+
import com.carrotsearch.randomizedtesting.annotations.ParametersFactory;
12+
13+
import org.opensearch.action.index.IndexRequestBuilder;
14+
import org.opensearch.action.search.SearchResponse;
15+
import org.opensearch.common.settings.Settings;
16+
import org.opensearch.test.ParameterizedStaticSettingsOpenSearchIntegTestCase;
17+
18+
import java.util.ArrayList;
19+
import java.util.Arrays;
20+
import java.util.Collection;
21+
import java.util.List;
22+
23+
import static org.opensearch.search.SearchService.CLUSTER_CONCURRENT_SEGMENT_SEARCH_SETTING;
24+
import static org.opensearch.search.SearchService.CONCURRENT_SEGMENT_SEARCH_PARTITION_MIN_SEGMENT_SIZE;
25+
import static org.opensearch.search.SearchService.CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY;
26+
import static org.opensearch.search.aggregations.AggregationBuilders.min;
27+
import static org.opensearch.test.hamcrest.OpenSearchAssertions.assertSearchResponse;
28+
import static org.hamcrest.Matchers.closeTo;
29+
import static org.hamcrest.Matchers.notNullValue;
30+
31+
/**
32+
* Integration tests for min aggregation with concurrent segment search partition strategies.
33+
*/
34+
public class MinIT extends ParameterizedStaticSettingsOpenSearchIntegTestCase {
35+
36+
public MinIT(Settings staticSettings) {
37+
super(staticSettings);
38+
}
39+
40+
@ParametersFactory
41+
public static Collection<Object[]> parameters() {
42+
return Arrays.asList(
43+
new Object[] { Settings.builder().put(CLUSTER_CONCURRENT_SEGMENT_SEARCH_SETTING.getKey(), false).build() },
44+
new Object[] { Settings.builder().put(CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY.getKey(), "segment").build() },
45+
new Object[] { Settings.builder().put(CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY.getKey(), "force").build() },
46+
new Object[] {
47+
Settings.builder()
48+
.put(CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY.getKey(), "balanced")
49+
.put(CONCURRENT_SEGMENT_SEARCH_PARTITION_MIN_SEGMENT_SIZE.getKey(), 1000)
50+
.build() }
51+
);
52+
}
53+
54+
public void testMinAggregation() throws Exception {
55+
createIndex("test_min_agg", Settings.builder().put("index.number_of_shards", 2).put("index.number_of_replicas", 1).build());
56+
try {
57+
List<IndexRequestBuilder> builders = new ArrayList<>(5000);
58+
for (int i = 0; i < 5000; i++) {
59+
builders.add(client().prepareIndex("test_min_agg").setSource("value", i + 1));
60+
}
61+
indexBulkWithSegments(builders, 2);
62+
indexRandomForConcurrentSearch("test_min_agg");
63+
SearchResponse response = client().prepareSearch("test_min_agg").addAggregation(min("min_agg").field("value")).get();
64+
assertSearchResponse(response);
65+
Min minAgg = response.getAggregations().get("min_agg");
66+
assertThat(minAgg, notNullValue());
67+
assertThat(minAgg.getValue(), closeTo(1.0, 0.1));
68+
} finally {
69+
internalCluster().wipeIndices("test_min_agg");
70+
}
71+
}
72+
}

‎server/src/internalClusterTest/java/org/opensearch/search/aggregations/metrics/StatsIT.java‎

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,10 @@
3131

3232
package org.opensearch.search.aggregations.metrics;
3333

34+
import com.carrotsearch.randomizedtesting.annotations.ParametersFactory;
35+
3436
import org.apache.logging.log4j.message.ParameterizedMessage;
37+
import org.opensearch.action.index.IndexRequestBuilder;
3538
import org.opensearch.action.search.SearchResponse;
3639
import org.opensearch.action.search.ShardSearchFailure;
3740
import org.opensearch.common.settings.Settings;
@@ -46,12 +49,17 @@
4649
import org.opensearch.search.aggregations.bucket.histogram.Histogram;
4750
import org.opensearch.search.aggregations.bucket.terms.Terms;
4851

52+
import java.util.ArrayList;
53+
import java.util.Arrays;
4954
import java.util.Collection;
5055
import java.util.Collections;
5156
import java.util.List;
5257

5358
import static org.opensearch.index.query.QueryBuilders.matchAllQuery;
5459
import static org.opensearch.index.query.QueryBuilders.termQuery;
60+
import static org.opensearch.search.SearchService.CLUSTER_CONCURRENT_SEGMENT_SEARCH_SETTING;
61+
import static org.opensearch.search.SearchService.CONCURRENT_SEGMENT_SEARCH_PARTITION_MIN_SEGMENT_SIZE;
62+
import static org.opensearch.search.SearchService.CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY;
5563
import static org.opensearch.search.aggregations.AggregationBuilders.filter;
5664
import static org.opensearch.search.aggregations.AggregationBuilders.global;
5765
import static org.opensearch.search.aggregations.AggregationBuilders.histogram;
@@ -60,6 +68,7 @@
6068
import static org.opensearch.test.hamcrest.OpenSearchAssertions.assertAcked;
6169
import static org.opensearch.test.hamcrest.OpenSearchAssertions.assertHitCount;
6270
import static org.opensearch.test.hamcrest.OpenSearchAssertions.assertSearchResponse;
71+
import static org.hamcrest.Matchers.closeTo;
6372
import static org.hamcrest.Matchers.equalTo;
6473
import static org.hamcrest.Matchers.is;
6574
import static org.hamcrest.Matchers.notNullValue;
@@ -70,6 +79,20 @@ public StatsIT(Settings staticSettings) {
7079
super(staticSettings);
7180
}
7281

82+
@ParametersFactory
83+
public static Collection<Object[]> parameters() {
84+
return Arrays.asList(
85+
new Object[] { Settings.builder().put(CLUSTER_CONCURRENT_SEGMENT_SEARCH_SETTING.getKey(), false).build() },
86+
new Object[] { Settings.builder().put(CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY.getKey(), "segment").build() },
87+
new Object[] { Settings.builder().put(CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY.getKey(), "force").build() },
88+
new Object[] {
89+
Settings.builder()
90+
.put(CONCURRENT_SEGMENT_SEARCH_PARTITION_STRATEGY.getKey(), "balanced")
91+
.put(CONCURRENT_SEGMENT_SEARCH_PARTITION_MIN_SEGMENT_SIZE.getKey(), 1000)
92+
.build() }
93+
);
94+
}
95+
7396
@Override
7497
protected Collection<Class<? extends Plugin>> nodePlugins() {
7598
return Collections.singleton(AggregationTestScriptsPlugin.class);
@@ -390,4 +413,28 @@ public void testScriptCaching() throws Exception {
390413
);
391414
internalCluster().wipeIndices("cache_test_idx");
392415
}
416+
417+
public void testStatsWithIntraSegmentPartitioning() throws Exception {
418+
createIndex("test_stats_agg", Settings.builder().put("index.number_of_shards", 2).put("index.number_of_replicas", 1).build());
419+
try {
420+
long expectedSum = 0;
421+
List<IndexRequestBuilder> builders = new ArrayList<>(5000);
422+
for (int i = 0; i < 5000; i++) {
423+
expectedSum += (i + 1);
424+
builders.add(client().prepareIndex("test_stats_agg").setSource("value", i + 1));
425+
}
426+
indexBulkWithSegments(builders, 2);
427+
indexRandomForConcurrentSearch("test_stats_agg");
428+
SearchResponse response = client().prepareSearch("test_stats_agg").addAggregation(stats("stats").field("value")).get();
429+
Stats statsAgg = response.getAggregations().get("stats");
430+
assertThat(statsAgg, notNullValue());
431+
assertThat(statsAgg.getCount(), equalTo(5000L));
432+
assertThat(statsAgg.getMin(), closeTo(1.0, 0.1));
433+
assertThat(statsAgg.getMax(), closeTo(5000.0, 0.1));
434+
assertThat(statsAgg.getSum(), closeTo((double) expectedSum, 0.1));
435+
assertThat(statsAgg.getAvg(), closeTo((double) expectedSum / 5000, 0.1));
436+
} finally {
437+
internalCluster().wipeIndices("test_stats_agg");
438+
}
439+
}
393440
}

0 commit comments

Comments
 (0)