Skip to content

Commit 24a2d68

Browse files
authored
Remove flaky assertion in FullClusterRestartIT.testRecovery (opensearch-project#20747)
The test asserts that after a full cluster restart upgrade, at least one old version Lucene segment must still exist on the primary. This is not guaranteed because background merges can merge all old version segments into new segments before the assertion runs. The remaining assertions still validate that translog replay occurred and produced at least one new-version segment on the primary. Signed-off-by: Andrew Ross <andrross@amazon.com>
1 parent 4ecd720 commit 24a2d68

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

qa/full-cluster-restart/src/test/java/org/opensearch/upgrades/FullClusterRestartIT.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -793,7 +793,6 @@ public void testRecovery() throws Exception {
793793
}
794794
assertNotEquals("expected at least 1 current segment after translog recovery. segments:\n" + segmentsResponse,
795795
0, numCurrentVersion);
796-
assertNotEquals("expected at least 1 old segment. segments:\n" + segmentsResponse, 0, numBwcVersion);
797796
}
798797
}
799798
}

0 commit comments

Comments
 (0)