Include exception details on failure

Signed-off-by: Andrew Ross <andrross@amazon.com>

Author: andrross

server/src/internalClusterTest/java/org/opensearch/search/SearchWeightedRoutingIT.java

@@ -461,7 +461,7 @@ public void testShardRoutingWithNetworkDisruption_FailOpenDisabled() throws Exce
                     hitNodes.add(searchResponse.getHits().getAt(j).getShard().getNodeId());
                 }
             } catch (Exception t) {
-                fail("search should not fail");
+                throw new AssertionError("search should not fail", t);
             }
         }
         Assert.assertTrue(failedShardCount > 0);
@@ -537,7 +537,7 @@ public void testShardRoutingWithNetworkDisruption_FailOpenEnabled() throws Excep
                     hitNodes.add(searchResponse.getHits().getAt(j).getShard().getNodeId());
                 }
             } catch (Exception t) {
-                fail("search should not fail");
+                throw new AssertionError("search should not fail", t);
             }
         }
 
@@ -604,7 +604,7 @@ public void testStrictWeightedRoutingWithCustomString_FailOpenEnabled() throws E
                     hitNodes.add(searchResponse.getHits().getAt(j).getShard().getNodeId());
                 }
             } catch (Exception t) {
-                fail("search should not fail");
+                throw new AssertionError("search should not fail", t);
             }
         }
 
@@ -674,7 +674,7 @@ public void testStrictWeightedRoutingWithCustomString_FailOpenDisabled() throws
                     hitNodes.add(searchResponse.getHits().getAt(j).getShard().getNodeId());
                 }
             } catch (Exception t) {
-                fail("search should not fail");
+                throw new AssertionError("search should not fail", t);
             }
         }
 
@@ -762,7 +762,7 @@ public void testStrictWeightedRoutingWithShardPrefNetworkDisruption_FailOpenEnab
                 SearchResponse searchResponse = responses[i].get();
                 assertEquals(searchResponse.getFailedShards(), 0);
             } catch (Exception t) {
-                fail("search should not fail");
+                throw new AssertionError("search should not fail", t);
             }
         }
 
@@ -825,7 +825,7 @@ public void testStrictWeightedRoutingWithShardPref() throws Exception {
                 assertEquals(searchResponse.getFailedShards(), 0);
                 assertNotEquals(searchResponse.getHits().getTotalHits().value(), 0);
             } catch (Exception t) {
-                fail("search should not fail");
+                throw new AssertionError("search should not fail", t);
             }
         }
         assertNoSearchInAZ("c");
@@ -959,7 +959,7 @@ public void testSearchAggregationWithNetworkDisruption_FailOpenEnabled() throws
                     hitNodes.add(searchResponse.getHits().getAt(j).getShard().getNodeId());
                 }
             } catch (Exception t) {
-                fail("search should not fail");
+                throw new AssertionError("search should not fail", t);
             }
         }
         networkDisruption.stopDisrupting();
@@ -1036,7 +1036,7 @@ public void testMultiGetWithNetworkDisruption_FailOpenEnabled() throws Exception
                 assertThat(multiGetResponse.getResponses()[0].isFailed(), equalTo(false));
                 assertThat(multiGetResponse.getResponses()[1].isFailed(), equalTo(false));
             } catch (Exception t) {
-                fail("search should not fail");
+                throw new AssertionError("search should not fail", t);
             }
         }
 
@@ -1108,7 +1108,7 @@ public void testMultiGetWithNetworkDisruption_FailOpenDisabled() throws Exceptio
                     failedCount++;
                 }
             } catch (Exception t) {
-                fail("search should not fail");
+                throw new AssertionError("search should not fail", t);
             }
         }
 
@@ -1451,7 +1451,7 @@ public void testWeightedRoutingFailOpenStats() throws Exception {
                 hitNodes.add(searchResponse.getHits().getAt(j).getShard().getNodeId());
             }
         } catch (Exception t) {
-            fail("search should not fail");
+            throw new AssertionError("search should not fail", t);
         }
         assertSearchInAZ("b");
         assertSearchInAZ("c");