Fix random version bug in NodeMetadataTests (opensearch-project#20253)

Stop generating raw ids and instead pick a version from the set of known
Version constants which are guaranteed to be valid/masked.

Signed-off-by: Joe Liu <guoqing4@illinois.edu>

Author: liuguoqingfz

server/src/test/java/org/opensearch/env/NodeMetadataTests.java

@@ -49,7 +49,10 @@ public class NodeMetadataTests extends OpenSearchTestCase {
     private Version randomVersion() {
         // VersionUtils.randomVersion() only returns known versions, which are necessarily no later than Version.CURRENT; however we want
         // also to consider our behaviour with all versions, so occasionally pick up a truly random version.
-        return rarely() ? Version.fromId(randomInt()) : VersionUtils.randomVersion(random());
+        //
+        // Version.fromId(...) requires the OpenSearch mask to be present, so we must generate ids in the valid masked range.
+        // The maximum id used elsewhere in this test class is 234217727 (see tooNewVersion()).
+        return rarely() ? Version.fromId(between(MASK, 234217727)) : VersionUtils.randomVersion(random());
     }
 
     public void testEqualsHashcodeSerialization() {