Added String constructor with 2 arguments

Author: andsel

logstash-core/lib/logstash/environment.rb

@@ -77,7 +77,7 @@ module Environment
          Setting::PortRange.new("api.http.port", 9600..9700),
             Setting::StringSetting.new("api.environment", "production"),
             Setting::StringSetting.new("api.auth.type", "none", true, %w(none basic)),
-            Setting::String.new("api.auth.basic.username", nil, false).nullable,
+            Setting::StringSetting.new("api.auth.basic.username", nil, false).nullable,
           Setting::Password.new("api.auth.basic.password", nil, false).nullable,
             Setting::StringSetting.new("api.auth.basic.password_policy.mode", "WARN", true, %w[WARN ERROR]),
            Setting::Numeric.new("api.auth.basic.password_policy.length.minimum", 8),
@@ -108,7 +108,7 @@ module Environment
          Setting::TimeValue.new("slowlog.threshold.debug", "-1"),
          Setting::TimeValue.new("slowlog.threshold.trace", "-1"),
             Setting::StringSetting.new("keystore.classname", "org.logstash.secret.store.backend.JavaKeyStore"),
-            Setting::String.new("keystore.file", ::File.join(::File.join(LogStash::Environment::LOGSTASH_HOME, "config"), "logstash.keystore"), false), # will be populated on
+            Setting::StringSetting.new("keystore.file", ::File.join(::File.join(LogStash::Environment::LOGSTASH_HOME, "config"), "logstash.keystore"), false), # will be populated on
     Setting::NullableString.new("monitoring.cluster_uuid"),
             Setting::StringSetting.new("pipeline.buffer.type", "direct", true, ["direct", "heap"])
   # post_process

logstash-core/src/main/java/org/logstash/settings/StringSetting.java

@@ -21,6 +21,10 @@ public StringSetting(String name, String defaultValue) {
         this(name, defaultValue, true, Collections.emptyList());
     }
 
+    public StringSetting(String name, String defaultValue, boolean strict) {
+        this(name, defaultValue, strict, Collections.emptyList());
+    }
+
     @Override
     public void validate(String input) throws IllegalArgumentException {
         staticValidate(input, possibleStrings, this.getName());