Skip to content

Commit aea7aec

Browse files
authored
Merge pull request #590 from vladimir-ch/docs-close-body-transition
{Cloud/On premise}/Issue: add missing comments about closing Response.Body
2 parents 58a1181 + 9c3184e commit aea7aec

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

cloud/issue.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1195,6 +1195,7 @@ func (s *IssueService) GetTransitions(ctx context.Context, id string) ([]Transit
11951195
// When performing the transition you can update or set other issue fields.
11961196
//
11971197
// Jira API docs: https://docs.atlassian.com/jira/REST/latest/#api/2/issue-doTransition
1198+
// Caller must close Response.Body
11981199
//
11991200
// TODO Double check this method if this works as expected, is using the latest API and the response is complete
12001201
// This double check effort is done for v2 - Remove this two lines if this is completed.
@@ -1500,6 +1501,7 @@ func (s *IssueService) AddRemoteLink(ctx context.Context, issueID string, remote
15001501
// UpdateRemoteLink updates a remote issue link by linkID.
15011502
//
15021503
// Jira API docs: https://developer.atlassian.com/cloud/jira/platform/rest/v2/api-group-issue-remote-links/#api-rest-api-2-issue-issueidorkey-remotelink-linkid-put
1504+
// Caller must close Response.Body
15031505
//
15041506
// TODO Double check this method if this works as expected, is using the latest API and the response is complete
15051507
// This double check effort is done for v2 - Remove this two lines if this is completed.

onpremise/issue.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1195,6 +1195,7 @@ func (s *IssueService) GetTransitions(ctx context.Context, id string) ([]Transit
11951195
// When performing the transition you can update or set other issue fields.
11961196
//
11971197
// Jira API docs: https://docs.atlassian.com/jira/REST/latest/#api/2/issue-doTransition
1198+
// Caller must close Response.Body
11981199
//
11991200
// TODO Double check this method if this works as expected, is using the latest API and the response is complete
12001201
// This double check effort is done for v2 - Remove this two lines if this is completed.
@@ -1500,6 +1501,7 @@ func (s *IssueService) AddRemoteLink(ctx context.Context, issueID string, remote
15001501
// UpdateRemoteLink updates a remote issue link by linkID.
15011502
//
15021503
// Jira API docs: https://developer.atlassian.com/cloud/jira/platform/rest/v2/api-group-issue-remote-links/#api-rest-api-2-issue-issueidorkey-remotelink-linkid-put
1504+
// Caller must close Response.Body
15031505
//
15041506
// TODO Double check this method if this works as expected, is using the latest API and the response is complete
15051507
// This double check effort is done for v2 - Remove this two lines if this is completed.

0 commit comments

Comments
 (0)