Commit 6508985
committed
Fix CLOB/BLOB insertion when prepared_statements is false
When prepared_statements is disabled, INSERT statements use empty_clob()/
empty_blob() literals instead of bind parameters. The LOB module previously
only had after_update callbacks, causing LOB data to be lost on INSERT.
This commonly occurs in Rails 8 development environments where
config.active_record.query_log_tags_enabled = true (the default) causes
Rails to automatically disable prepared statements.
Changes:
- Add before_create :record_lobs_for_create callback
- Add after_create :enhanced_write_lobs callback
- Add record_lobs_for_create method to track non-nil LOB columns on create
- Skip callback when prepared_statements is enabled (LOB data already
written via temporary LOB binding in type_cast())
Fixes rsim#2477 (CLOBs empty after creation)
Fixes rsim#2483 (redundant double-write with prepared statements)1 parent 04841ad commit 6508985
File tree
2 files changed
+63
-0
lines changed- lib/active_record/connection_adapters/oracle_enhanced
- spec/active_record/oracle_enhanced/type
2 files changed
+63
-0
lines changedLines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
14 | 16 | | |
15 | 17 | | |
16 | 18 | | |
| |||
25 | 27 | | |
26 | 28 | | |
27 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
28 | 33 | | |
29 | 34 | | |
30 | 35 | | |
31 | 36 | | |
32 | 37 | | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
33 | 45 | | |
34 | 46 | | |
35 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
241 | 241 | | |
242 | 242 | | |
243 | 243 | | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
244 | 295 | | |
0 commit comments