fix: skip chmod setting in readonly mode

andyzhangx · andyzhangx · commit 229c015089e0 · 2025-11-06T14:04:35.000Z
diff --git a/pkg/blob/nodeserver.go b/pkg/blob/nodeserver.go
@@ -389,8 +389,12 @@ func (d *Driver) NodeStageVolume(ctx context.Context, req *csi.NodeStageVolumeRe
 		}
 
 		if performChmodOp {
-			if err := chmodIfPermissionMismatch(targetPath, os.FileMode(mountPermissions)); err != nil {
-				return nil, status.Error(codes.Internal, err.Error())
+			if !isReadOnlyFromCapability(volumeCapability) {
+				if err := chmodIfPermissionMismatch(targetPath, os.FileMode(mountPermissions)); err != nil {
+					return nil, status.Error(codes.Internal, err.Error())
+				}
+			} else {
+				klog.V(2).Infof("skip chmod on targetPath(%s) since it's a read-only mount", targetPath)
 			}
 		} else {
 			klog.V(2).Infof("skip chmod on targetPath(%s) since mountPermissions is set as 0", targetPath)

Original file line number	Diff line number	Diff line change
`@@ -389,8 +389,12 @@ func (d Driver) NodeStageVolume(ctx context.Context, req csi.NodeStageVolumeRe`
`389`	`389`	`}`
`390`	`390`
`391`	`391`	`if performChmodOp {`
`392`		`- if err := chmodIfPermissionMismatch(targetPath, os.FileMode(mountPermissions)); err != nil {`
`393`		`- return nil, status.Error(codes.Internal, err.Error())`
	`392`	`+ if !isReadOnlyFromCapability(volumeCapability) {`
	`393`	`+ if err := chmodIfPermissionMismatch(targetPath, os.FileMode(mountPermissions)); err != nil {`
	`394`	`+ return nil, status.Error(codes.Internal, err.Error())`
	`395`	`+ }`
	`396`	`+ } else {`
	`397`	`+ klog.V(2).Infof("skip chmod on targetPath(%s) since it's a read-only mount", targetPath)`
`394`	`398`	`}`
`395`	`399`	`} else {`
`396`	`400`	`klog.V(2).Infof("skip chmod on targetPath(%s) since mountPermissions is set as 0", targetPath)`