fix(nf-core): typo in info about caching shared bundles

Author: manfredsteyer

libs/mf/src/schematics/mf/files/webpack.config.js renamed to libs/mf/src/schematics/mf/files/webpack.config.js__tmpl__

@@ -171,6 +171,7 @@ async function generateWebpackConfig(
       projectSourceRoot,
       remoteMap,
       ...options,
+      tmpl: '',
     }),
     move(projectRoot),
   ]);

libs/mf/src/schematics/mf/schematic.ts

@@ -22,4 +22,4 @@ export {
   BuildHelperParams,
 } from './lib/core/federation-builder';
 export { logger, setLogLevel } from './lib/utils/logger';
-export { hashFile } from './lib/utils/hash-file';
+export { hashFile } from './lib/utils/hash-file';

libs/native-federation-core/src/build.ts

@@ -20,12 +20,15 @@ export async function bundleShared(
     .map((packageName) => getPackageInfo(packageName, fedOptions.workspaceRoot))
     .filter((pi) => !!pi) as PackageInfo[];
 
-  logger.notice('Shared packages are only bundles once as they are cached');
+  logger.notice('Shared packages are only bundled once as they are cached');
   logger.notice(
-    'Make sure, you skip all unneeded packages in your federation.config.js'
+    'Make sure, you skip all unneeded packages in your federation.config.js!'
   );
 
-  const federationConfigPath = path.join(fedOptions.workspaceRoot, fedOptions.federationConfig);
+  const federationConfigPath = path.join(
+    fedOptions.workspaceRoot,
+    fedOptions.federationConfig
+  );
   const hash = hashFile(federationConfigPath);
 
   for (const pi of packageInfos) {

libs/native-federation-core/src/lib/core/bundle-shared.ts

@@ -45,7 +45,9 @@ async function processRemoteInfos(
       const remoteMap = await processRemoteInfo(url, remoteName);
       importMap = mergeImportMaps(importMap, remoteMap);
     } catch (e) {
-      console.error(`Error loading remote entry for ${remoteName} from file ${remotes[remoteName]}`);
+      console.error(
+        `Error loading remote entry for ${remoteName} from file ${remotes[remoteName]}`
+      );
     }
   }
 

libs/native-federation-runtime/src/lib/init-federation.ts

@@ -72,12 +72,11 @@ function runNgccIfNeeded(fedOptions: FederationOptions, workspaceRoot: string) {
 function runNgcc(workspaceRoot: string) {
   logger.verbose('Running ngcc');
   const command = getNpxCommand(workspaceRoot);
-  const result = crossSpawn.sync(command, [
-    'ngcc',
-    '--async',
-    '--create-ivy-entry-points',
-    '--first-only'
-  ], { stdio: 'inherit' });
+  const result = crossSpawn.sync(
+    command,
+    ['ngcc', '--async', '--create-ivy-entry-points', '--first-only'],
+    { stdio: 'inherit' }
+  );
 
   if (result.status !== 0) {
     const error = result.error || '';
@@ -94,7 +93,6 @@ function getLockFileHash(fedOptions: FederationOptions) {
 const NGCC_LOCK_DIR = 'node_modules/.cache/native-federation/ngcc';
 
 function skipNgcc(hash: string, workspaceRoot: string) {
-  
   const ngccLockFileDir = path.join(workspaceRoot, NGCC_LOCK_DIR);
   const ngccLockFileName = path.join(ngccLockFileDir, hash + '.lock');
 
@@ -129,10 +127,14 @@ function getLockFileName(workspaceRoot: string) {
 
 function getNpxCommand(workspaceRoot: string): string {
   switch (getLockFileName(workspaceRoot)) {
-    case 'package-lock.json': return 'npx';
-    case 'yarn.lock': return 'yarn';
-    case 'pnpm-lock.yaml': return 'pnpx';
-    default: return 'npx';
+    case 'package-lock.json':
+      return 'npx';
+    case 'yarn.lock':
+      return 'yarn';
+    case 'pnpm-lock.yaml':
+      return 'pnpx';
+    default:
+      return 'npx';
   }
 }
 

libs/native-federation/src/builders/build/builder.ts

@@ -265,6 +265,7 @@ async function generateFederationConfig(
       projectSourceRoot,
       remoteMap,
       ...options,
+      tmpl: '',
     }),
     move(projectRoot),
   ]);

libs/native-federation/src/schematics/init/files/federation.config.js renamed to libs/native-federation/src/schematics/init/files/federation.config.js__tmpl__

@@ -28,6 +28,7 @@
     "dep-graph": "nx dep-graph",
     "help": "nx help"
   },
+  "precommit": "format:write",
   "private": true,
   "dependencies": {
     "@angular-architects/module-federation": "file:angular-architects-module-federation-14.3.10.tgz",
@@ -105,6 +106,7 @@
     "postcss-import": "14.1.0",
     "postcss-preset-env": "7.5.0",
     "postcss-url": "10.1.3",
+    "pre-commit": "^1.2.2",
     "prettier": "2.6.2",
     "rollup": "^2.79.0",
     "rollup-plugin-node-externals": "^4.1.1",