Skip to content

Commit 3ca01ed

Browse files
author
Alain Sollberger
committed
feat(ssr-perf-check): check whether server side rendering is used
- performance gain by not bundling for the server when ssr is not in use
1 parent f9a28bf commit 3ca01ed

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

libs/native-federation-core/src/lib/core/build-for-federation.ts

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,9 @@ export async function buildForFederation(
5858
'browser'
5959
);
6060

61-
const sharedPackageInfoServer = await bundleShared(
62-
sharedServer,
63-
config,
64-
fedOptions,
65-
externals,
66-
'node'
67-
);
61+
const sharedPackageInfoServer = fedOptions.ssr
62+
? await bundleShared(sharedServer, config, fedOptions, externals, 'node')
63+
: [];
6864

6965
const separatePackageInfoBrowser = await bundleSeparate(
7066
separateBrowser,
@@ -74,13 +70,15 @@ export async function buildForFederation(
7470
'browser'
7571
);
7672

77-
const separatePackageInfoServer = await bundleSeparate(
78-
separateServer,
79-
externals,
80-
config,
81-
fedOptions,
82-
'node'
83-
);
73+
const separatePackageInfoServer = fedOptions.ssr
74+
? await bundleSeparate(
75+
separateServer,
76+
externals,
77+
config,
78+
fedOptions,
79+
'node'
80+
)
81+
: [];
8482

8583
sharedPackageInfoCache = [
8684
...sharedPackageInfoBrowser,

libs/native-federation-core/src/lib/core/federation-options.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ export interface FederationOptions {
88
verbose?: boolean;
99
dev?: boolean;
1010
watch?: boolean;
11+
ssr?: boolean;
1112
packageJson?: string;
1213
entryPoint?: string;
1314
buildNotifications?: BuildNotificationOptions;

libs/native-federation/src/builders/build/builder.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ export async function* runBuilder(
204204
verbose: options.verbose,
205205
watch: false, // options.watch,
206206
dev: !!nfOptions.dev,
207+
ssr: !!nfOptions.ssr,
207208
entryPoint,
208209
buildNotifications: nfOptions.buildNotifications,
209210
};

0 commit comments

Comments
 (0)