fix(nf): fix shared mappings plugin

Author: manfredsteyer

libs/native-federation/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@angular-architects/native-federation",
-  "version": "17.0.6",
+  "version": "17.0.7",
   "main": "src/index.js",
   "generators": "./collection.json",
   "builders": "./builders.json",

libs/native-federation/src/builders/build/builder.ts

@@ -39,6 +39,7 @@ import {
   NgCliAssetResult,
 } from '../../utils/mem-resuts';
 import { JsonObject } from '@angular-devkit/core';
+import { createSharedMappingsPlugin } from '../../utils/shared-mappings-plugin';
 
 export async function* runBuilder(
   nfOptions: NfBuilderSchema,
@@ -82,6 +83,7 @@ export async function* runBuilder(
 
   // options.externalDependencies = externals.filter((e) => e !== 'tslib');
   const plugins = [
+    createSharedMappingsPlugin(config.sharedMappings),
     {
       name: 'externals',
       setup(build) {

libs/native-federation/src/utils/shared-mappings-plugin.ts

@@ -8,17 +8,20 @@ export function createSharedMappingsPlugin(mappedPaths: MappedPath[]): Plugin {
     setup(build: PluginBuild) {
       build.onResolve({ filter: /^[.]/ }, async (args) => {
         let mappedPath: MappedPath | null = null;
-        if (
-          args.path.includes('playground-lib') &&
-          args.kind === 'import-statement'
-        ) {
+        let isSelf = false;
+
+        if (args.kind === 'import-statement') {
           const importPath = path.join(args.resolveDir, args.path);
           mappedPath = mappedPaths.find((p) =>
             importPath.startsWith(path.dirname(p.path))
           );
         }
 
         if (mappedPath) {
+          isSelf = args.importer.startsWith(path.dirname(mappedPath.path));
+        }
+
+        if (mappedPath && !isSelf) {
           return {
             path: mappedPath.key,
             external: true,

update-local.bat

@@ -1,7 +1,7 @@
-call npm unpublish @softarc/native-federation@2.0.5 --registry http://localhost:4873
-call npm unpublish @softarc/native-federation-runtime@2.0.5 --registry http://localhost:4873
-call npm unpublish @softarc/native-federation-esbuild@2.0.5 --registry http://localhost:4873
-call npm unpublish @angular-architects/native-federation@17.0.3 --registry http://localhost:4873
+call npm unpublish @softarc/native-federation@2.0.7 --registry http://localhost:4873
+call npm unpublish @softarc/native-federation-runtime@2.0.7 --registry http://localhost:4873
+call npm unpublish @softarc/native-federation-esbuild@2.0.7 --registry http://localhost:4873
+call npm unpublish @angular-architects/native-federation@17.0.7 --registry http://localhost:4873
 
 call npx nx build native-federation
 call npx nx build native-federation-core