fix(nf-core): when probing folders for secondary entry points, don't traverse node_modules

Author: manfredsteyer

libs/mf/README.md

@@ -22,7 +22,7 @@ Module Federation allows loading separately compiled and deployed code (like mic
 
 ## Supporting Several Technologies
 
-✅ Supports webpack, rsbuild (experimental, nextgen), esbuild 
+✅ Supports webpack, rsbuild (experimental, nextgen), esbuild
 
 ✅ Supports Module Federation and Native Federation
 

libs/mf/src/utils/share-utils.ts

@@ -101,7 +101,7 @@ function _findSecondaries(
 
   const dirs = files
     .map((f) => path.join(libPath, f))
-    .filter((f) => fs.lstatSync(f).isDirectory() && f !== 'node_modules');
+    .filter((f) => fs.lstatSync(f).isDirectory() && !f.endsWith('node_modules'));
 
   const secondaries = dirs.filter((d) =>
     fs.existsSync(path.join(d, 'package.json'))

libs/native-federation-core/package.json

@@ -1,11 +1,11 @@
 {
   "name": "@softarc/native-federation",
-  "version": "2.0.15",
+  "version": "2.0.16",
   "type": "commonjs",
   "license": "MIT",
   "dependencies": {
     "json5": "^2.2.0",
     "npmlog": "^6.0.2",
-    "@softarc/native-federation-runtime": "2.0.15"
+    "@softarc/native-federation-runtime": "2.0.16"
   }
 }

libs/native-federation-core/src/lib/config/share-utils.ts

@@ -112,7 +112,7 @@ function _findSecondaries(
 
   const secondaries = files
     .map((f) => path.join(libPath, f))
-    .filter((f) => fs.lstatSync(f).isDirectory() && f !== 'node_modules');
+    .filter((f) => fs.lstatSync(f).isDirectory() && !f.endsWith('node_modules'));
 
   for (const s of secondaries) {
     if (fs.existsSync(path.join(s, 'package.json'))) {

libs/native-federation-esbuild/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@softarc/native-federation-esbuild",
-  "version": "2.0.15",
+  "version": "2.0.16",
   "type": "commonjs",
   "dependencies": {
     "@rollup/plugin-commonjs": "^22.0.2",

libs/native-federation-node/package.json

@@ -1,4 +1,4 @@
 {
   "name": "@softarc/native-federation-node",
-  "version": "2.0.15"
+  "version": "2.0.16"
 }

libs/native-federation-runtime/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@softarc/native-federation-runtime",
-  "version": "2.0.15",
+  "version": "2.0.16",
   "dependencies": {
     "tslib": "^2.3.0"
   },

libs/native-federation/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@angular-architects/native-federation",
-  "version": "19.0.2",
+  "version": "19.0.3",
   "main": "src/index.js",
   "generators": "./collection.json",
   "builders": "./builders.json",
@@ -20,8 +20,8 @@
   },
   "dependencies": {
     "@babel/core": "^7.19.0",
-    "@softarc/native-federation": "2.0.15",
-    "@softarc/native-federation-runtime": "2.0.15",
+    "@softarc/native-federation": "2.0.16",
+    "@softarc/native-federation-runtime": "2.0.16",
     "@types/browser-sync": "^2.29.0",
     "@chialab/esbuild-plugin-commonjs": "^0.18.0",
     "browser-sync": "^3.0.2",

libs/native-federation/src/utils/angular-esbuild-adapter.ts

@@ -281,7 +281,7 @@ async function runEsbuild(
     format: 'esm',
     target: ['esnext'],
     logLimit: kind === 'shared-package' ? 1 : 0,
-    plugins: plugins || [
+    plugins: plugins as any || [
       createCompilerPlugin(
         pluginOptions.pluginOptions,
         pluginOptions.styleOptions