fix: exit process on error

Author: manfredsteyer

libs/native-federation-core/src/build.ts

@@ -11,7 +11,7 @@ export {
   BuildAdapterOptions,
   BuildResult,
   BuildKind,
-  EntryPoint
+  EntryPoint,
 } from './lib/core/build-adapter';
 export { withNativeFederation } from './lib/config/with-native-federation';
 export { buildForFederation } from './lib/core/build-for-federation';

libs/native-federation/docs/share-faq.md

@@ -50,8 +50,8 @@ The skip list can contain a RegExp for excluding several entry points starting w
 
 ```typescript
 skip: [
-    'this-package', // string-based entry
-    'that-package', // another string-based one
-    /^my-package/   // RegExp
-]
+  'this-package', // string-based entry
+  'that-package', // another string-based one
+  /^my-package/, // RegExp
+];
 ```

libs/native-federation/src/builders/build/builder.ts

@@ -228,8 +228,7 @@ export async function* runBuilder(
 
   try {
     await buildForFederation(config, fedOptions, externals);
-  }
-  catch(e) {
+  } catch (e) {
     process.exit(1);
   }
 

libs/native-federation/src/plugin/index.ts

@@ -60,10 +60,7 @@ const configureDevServer = async (
   server.middlewares.use(serveFromDist(dist, fedInfo));
 };
 
-const serveFromDist = (
-  dist: string,
-  fedInfoRef: FedInfoRef
-) => {
+const serveFromDist = (dist: string, fedInfoRef: FedInfoRef) => {
   const fedFiles = new Set([
     ...fedInfoRef.federationInfo.shared.map((s) =>
       path.join('/', s.outFileName)

libs/native-federation/src/schematics/init/schematic.ts

@@ -14,7 +14,10 @@ import { NodePackageInstallTask } from '@angular-devkit/schematics/tasks';
 import { strings } from '@angular-devkit/core';
 import { MfSchematicSchema } from './schema';
 
-import { patchAngularBuildPackageJson, privateEntrySrc } from '../../utils/patch-angular-build';
+import {
+  patchAngularBuildPackageJson,
+  privateEntrySrc,
+} from '../../utils/patch-angular-build';
 
 import {
   addPackageJsonDependency,
@@ -45,16 +48,16 @@ export function updatePackageJson(tree: Tree): void {
   }
 
   let postInstall = (packageJson['scripts']?.['postinstall'] || '') as string;
-  
+
   if (!postInstall) {
     return;
   }
-  
+
   if (postInstall.includes(scriptCall)) {
     postInstall = postInstall.replace(scriptCall, '');
   }
   if (postInstall.endsWith(' && ')) {
-    postInstall = postInstall.substring(0, postInstall.length-4)
+    postInstall = postInstall.substring(0, postInstall.length - 4);
   }
 
   packageJson['scripts']['postinstall'] = postInstall;
@@ -125,19 +128,10 @@ export function patchAngularBuild(tree) {
     return;
   }
 
-  const packageJson = JSON.parse(
-    tree.read(packagePath)
-  );
+  const packageJson = JSON.parse(tree.read(packagePath));
   patchAngularBuildPackageJson(packageJson);
-  tree.overwrite(
-    packagePath,
-    JSON.stringify(packageJson, null, 2)
-  );
-  tree.overwrite(
-    privatePath,
-    privateEntrySrc
-  );
-
+  tree.overwrite(packagePath, JSON.stringify(packageJson, null, 2));
+  tree.overwrite(privatePath, privateEntrySrc);
 }
 
 function updateWorkspaceConfig(

libs/native-federation/src/utils/create-compiler-options.ts

@@ -2,65 +2,67 @@
 // Currently, this type cannot be accessed from the outside
 
 export function createCompilerPluginOptions(
-    options: any,
-    target: string[],
-    sourceFileCache?: any,
-  ): {
-    pluginOptions: any[0];
-    styleOptions: any[1];
-  } {
-    const {
-      workspaceRoot,
-      optimizationOptions,
-      sourcemapOptions,
+  options: any,
+  target: string[],
+  sourceFileCache?: any
+): {
+  pluginOptions: any[0];
+  styleOptions: any[1];
+} {
+  const {
+    workspaceRoot,
+    optimizationOptions,
+    sourcemapOptions,
+    tsconfig,
+    outputNames,
+    fileReplacements,
+    externalDependencies,
+    preserveSymlinks,
+    stylePreprocessorOptions,
+    advancedOptimizations,
+    inlineStyleLanguage,
+    jit,
+    cacheOptions,
+    tailwindConfiguration,
+    postcssConfiguration,
+    publicPath,
+  } = options;
+
+  return {
+    // JS/TS options
+    pluginOptions: {
+      sourcemap:
+        !!sourcemapOptions.scripts &&
+        (sourcemapOptions.hidden ? 'external' : true),
+      thirdPartySourcemaps: sourcemapOptions.vendor,
       tsconfig,
-      outputNames,
+      jit,
+      advancedOptimizations,
       fileReplacements,
+      sourceFileCache,
+      loadResultCache: sourceFileCache?.loadResultCache,
+      incremental: !!options.watch,
+    },
+    // Component stylesheet options
+    styleOptions: {
+      workspaceRoot,
+      inlineFonts: !!optimizationOptions.fonts.inline,
+      optimization: !!optimizationOptions.styles.minify,
+      sourcemap:
+        // Hidden component stylesheet sourcemaps are inaccessible which is effectively
+        // the same as being disabled. Disabling has the advantage of avoiding the overhead
+        // of sourcemap processing.
+        sourcemapOptions.styles && !sourcemapOptions.hidden ? 'linked' : false,
+      outputNames,
+      includePaths: stylePreprocessorOptions?.includePaths,
       externalDependencies,
-      preserveSymlinks,
-      stylePreprocessorOptions,
-      advancedOptimizations,
+      target,
       inlineStyleLanguage,
-      jit,
-      cacheOptions,
+      preserveSymlinks,
       tailwindConfiguration,
       postcssConfiguration,
+      cacheOptions,
       publicPath,
-    } = options;
-  
-    return {
-      // JS/TS options
-      pluginOptions: {
-        sourcemap: !!sourcemapOptions.scripts && (sourcemapOptions.hidden ? 'external' : true),
-        thirdPartySourcemaps: sourcemapOptions.vendor,
-        tsconfig,
-        jit,
-        advancedOptimizations,
-        fileReplacements,
-        sourceFileCache,
-        loadResultCache: sourceFileCache?.loadResultCache,
-        incremental: !!options.watch,
-      },
-      // Component stylesheet options
-      styleOptions: {
-        workspaceRoot,
-        inlineFonts: !!optimizationOptions.fonts.inline,
-        optimization: !!optimizationOptions.styles.minify,
-        sourcemap:
-          // Hidden component stylesheet sourcemaps are inaccessible which is effectively
-          // the same as being disabled. Disabling has the advantage of avoiding the overhead
-          // of sourcemap processing.
-          sourcemapOptions.styles && !sourcemapOptions.hidden ? 'linked' : false,
-        outputNames,
-        includePaths: stylePreprocessorOptions?.includePaths,
-        externalDependencies,
-        target,
-        inlineStyleLanguage,
-        preserveSymlinks,
-        tailwindConfiguration,
-        postcssConfiguration,
-        cacheOptions,
-        publicPath,
-      },
-    };
-  }
+    },
+  };
+}