fix(nf-node): Cannot read properties of undefined (reading 'cacheTag') #767

manfredsteyer · manfredsteyer · commit b5abc2829595 · 2025-02-28T16:56:52.000+01:00
diff --git a/libs/mf-runtime/package.json b/libs/mf-runtime/package.json
@@ -1,12 +1,12 @@
 {
   "name": "@angular-architects/module-federation-runtime",
   "license": "MIT",
-  "version": "19.0.1",
+  "version": "19.0.2",
   "peerDependencies": {
     "@angular/common": ">=18.0.0",
     "@angular/core": ">=18.0.0",
-    "@module-federation/enhanced": "^0.8.7",
-    "@module-federation/runtime-core": "^0.6.15"
+    "@module-federation/enhanced": "^0.9.0",
+    "@module-federation/runtime-core": "^0.6.21"
   },
   "dependencies": {
     "tslib": "^2.0.0"
diff --git a/libs/mf-tools/package.json b/libs/mf-tools/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@angular-architects/module-federation-tools",
-  "version": "19.0.1",
+  "version": "19.0.2",
   "license": "MIT",
   "peerDependencies": {},
   "dependencies": {
diff --git a/libs/mf/package.json b/libs/mf/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@angular-architects/module-federation",
-  "version": "19.0.1",
+  "version": "19.0.2",
   "license": "MIT",
   "repository": {
     "type": "GitHub",
@@ -17,7 +17,7 @@
   "schematics": "./collection.json",
   "builders": "./builders.json",
   "dependencies": {
-    "@angular-architects/module-federation-runtime": "19.0.1",
+    "@angular-architects/module-federation-runtime": "19.0.2",
     "word-wrap": "^1.2.3",
     "callsite": "^1.0.0",
     "node-fetch": "^2.6.7",
diff --git a/libs/mf/src/builders/build/builder.ts b/libs/mf/src/builders/build/builder.ts
@@ -18,4 +18,4 @@ export function runBuilder(
   );
 }
 
-export default createBuilder(runBuilder);
+export default createBuilder(runBuilder as any);
diff --git a/libs/native-federation-core/package.json b/libs/native-federation-core/package.json
@@ -1,11 +1,11 @@
 {
   "name": "@softarc/native-federation",
-  "version": "2.0.22",
+  "version": "2.0.23",
   "type": "commonjs",
   "license": "MIT",
   "dependencies": {
     "json5": "^2.2.0",
     "npmlog": "^6.0.2",
-    "@softarc/native-federation-runtime": "2.0.22"
+    "@softarc/native-federation-runtime": "2.0.23"
   }
 }
diff --git a/libs/native-federation-esbuild/package.json b/libs/native-federation-esbuild/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@softarc/native-federation-esbuild",
-  "version": "2.0.22",
+  "version": "2.0.23",
   "type": "commonjs",
   "dependencies": {
     "@rollup/plugin-commonjs": "^22.0.2",
diff --git a/libs/native-federation-node/package.json b/libs/native-federation-node/package.json
@@ -1,4 +1,4 @@
 {
   "name": "@softarc/native-federation-node",
-  "version": "2.0.22"
+  "version": "2.0.23"
 }
diff --git a/libs/native-federation-node/src/lib/node/init-node-federation.ts b/libs/native-federation-node/src/lib/node/init-node-federation.ts
@@ -74,11 +74,10 @@ async function loadFsManifest(
 
 async function loadFsFederationInfo(
   relBundlePath: string,
-  options?: InitFederationOptions
 ): Promise<FederationInfo> {
   const manifestPath = path.join(
     relBundlePath,
-    'remoteEntry.json' + options?.cacheTag ? `?t=${options.cacheTag}` : ''
+    'remoteEntry.json'
   );
   const content = await fs.readFile(manifestPath, 'utf-8');
   const manifest = JSON.parse(content) as FederationInfo;
diff --git a/libs/native-federation-runtime/package.json b/libs/native-federation-runtime/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@softarc/native-federation-runtime",
-  "version": "2.0.22",
+  "version": "2.0.23",
   "dependencies": {
     "tslib": "^2.3.0"
   },
diff --git a/libs/native-federation/package.json b/libs/native-federation/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@angular-architects/native-federation",
-  "version": "19.0.10",
+  "version": "19.0.11",
   "main": "src/index.js",
   "generators": "./collection.json",
   "builders": "./builders.json",
@@ -20,8 +20,8 @@
   },
   "dependencies": {
     "@babel/core": "^7.19.0",
-    "@softarc/native-federation": "2.0.22",
-    "@softarc/native-federation-runtime": "2.0.22",
+    "@softarc/native-federation": "2.0.23",
+    "@softarc/native-federation-runtime": "2.0.23",
     "@types/browser-sync": "^2.29.0",
     "@chialab/esbuild-plugin-commonjs": "^0.18.0",
     "browser-sync": "^3.0.2",
diff --git a/libs/native-federation/src/schematics/init/schematic.ts b/libs/native-federation/src/schematics/init/schematic.ts
@@ -492,7 +492,7 @@ function makeServerAsync(
       )
       .replace(
         `const app = express();`,
-        `const app = express();\n  app.set('view engine', 'html');`
+        `const app = express();\n\tapp.use(cors());\n  app.set('view engine', 'html');`
       )
       .replace(`if (isMainModule(import.meta.url)) {`, ``)
       .replace(/\}(?![\s\S]*\})/, '');
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@angular-architects/module-federation-tools",`
`3`		`- "version": "19.0.1",`
	`3`	`+ "version": "19.0.2",`
`4`	`4`	`"license": "MIT",`
`5`	`5`	`"peerDependencies": {},`
`6`	`6`	`"dependencies": {`
Original file line number	Diff line number	Diff line change
`@@ -18,4 +18,4 @@ export function runBuilder(`
`18`	`18`	`);`
`19`	`19`	`}`
`20`	`20`
`21`		`-export default createBuilder(runBuilder);`
	`21`	`+export default createBuilder(runBuilder as any);`
Original file line number	Diff line number	Diff line change
`@@ -1,11 +1,11 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@softarc/native-federation",`
`3`		`- "version": "2.0.22",`
	`3`	`+ "version": "2.0.23",`
`4`	`4`	`"type": "commonjs",`
`5`	`5`	`"license": "MIT",`
`6`	`6`	`"dependencies": {`
`7`	`7`	`"json5": "^2.2.0",`
`8`	`8`	`"npmlog": "^6.0.2",`
`9`		`- "@softarc/native-federation-runtime": "2.0.22"`
	`9`	`+ "@softarc/native-federation-runtime": "2.0.23"`
`10`	`10`	`}`
`11`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@softarc/native-federation-esbuild",`
`3`		`- "version": "2.0.22",`
	`3`	`+ "version": "2.0.23",`
`4`	`4`	`"type": "commonjs",`
`5`	`5`	`"dependencies": {`
`6`	`6`	`"@rollup/plugin-commonjs": "^22.0.2",`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@softarc/native-federation-node",`
`3`		`- "version": "2.0.22"`
	`3`	`+ "version": "2.0.23"`
`4`	`4`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@softarc/native-federation-runtime",`
`3`		`- "version": "2.0.22",`
	`3`	`+ "version": "2.0.23",`
`4`	`4`	`"dependencies": {`
`5`	`5`	`"tslib": "^2.3.0"`
`6`	`6`	`},`