Skip to content

Commit d46d01a

Browse files
committed
fix(nf-core): make sheriff an ordinary dep
yarn does not automatically install peer-deps, hence in favor of DX, sheriff is now an ordinary dep.
1 parent f9a28bf commit d46d01a

File tree

7 files changed

+21
-11
lines changed

7 files changed

+21
-11
lines changed
Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
{
22
"name": "@softarc/native-federation",
3-
"version": "3.3.1",
3+
"version": "3.3.4",
44
"type": "commonjs",
55
"license": "MIT",
66
"dependencies": {
77
"json5": "^2.2.0",
88
"chalk": "^4.1.2",
9-
"@softarc/native-federation-runtime": "3.3.1",
10-
"fast-glob": "^3.3.3"
11-
},
12-
"peerDependencies": {
9+
"@softarc/native-federation-runtime": "3.3.4",
10+
"fast-glob": "^3.3.3",
1311
"@softarc/sheriff-core": "^0.18.2"
1412
}
1513
}

libs/native-federation-core/src/lib/core/load-federation-config.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ export async function loadFederationConfig(
2525
}
2626

2727
if (config.features.ignoreUnusedDeps) {
28+
// const entryPoint = path.join(fedOptions.workspaceRoot, fedOptions.entryPoint ?? '');
29+
2830
return removeUnusedDeps(
2931
config,
3032
fedOptions.entryPoint ?? '',

libs/native-federation-core/src/lib/utils/package-info.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,16 @@ export function _getPackageInfo(
350350
};
351351
}
352352

353+
// cand = secondaryPgkPath;
354+
// if (fs.existsSync(cand) && cand.match(/\.(m|c)?js$/)) {
355+
// return {
356+
// entryPoint: cand,
357+
// packageName,
358+
// version,
359+
// esm,
360+
// };
361+
// }
362+
353363
// TODO: Add logger
354364
logger.warn('No entry point found for ' + packageName);
355365
logger.warn(

libs/native-federation-esbuild/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@softarc/native-federation-esbuild",
3-
"version": "3.3.1",
3+
"version": "3.3.4",
44
"type": "commonjs",
55
"dependencies": {
66
"@rollup/plugin-commonjs": "^22.0.2",
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"name": "@softarc/native-federation-node",
3-
"version": "3.3.1",
3+
"version": "3.3.4",
44
"license": "MIT"
55
}

libs/native-federation-runtime/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@softarc/native-federation-runtime",
3-
"version": "3.3.1",
3+
"version": "3.3.4",
44
"dependencies": {
55
"tslib": "^2.3.0"
66
},

libs/native-federation/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@angular-architects/native-federation",
3-
"version": "20.1.2",
3+
"version": "20.1.5",
44
"main": "src/index.js",
55
"generators": "./collection.json",
66
"builders": "./builders.json",
@@ -20,8 +20,8 @@
2020
},
2121
"dependencies": {
2222
"@babel/core": "^7.19.0",
23-
"@softarc/native-federation": "3.3.1",
24-
"@softarc/native-federation-runtime": "3.3.1",
23+
"@softarc/native-federation": "3.3.4",
24+
"@softarc/native-federation-runtime": "3.3.4",
2525
"@chialab/esbuild-plugin-commonjs": "^0.18.0",
2626
"esbuild": "^0.25.1",
2727
"mrmime": "^1.0.1",

0 commit comments

Comments
 (0)