Skip to content

Commit ee6ffe9

Browse files
committed
fix: install ngx-build-plus via schematic to avoid issues with yarn
Before, ngx-build-plus was installed as a dependency. However, this caused issues with yarn as yarn was not able of resolving it for the CLI as a builder. Now, the ng-add/init schematic installs ngx-build-plus
1 parent f4b5dc2 commit ee6ffe9

File tree

4 files changed

+14
-18
lines changed

4 files changed

+14
-18
lines changed

libs/mf-runtime/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@angular-architects/module-federation-runtime",
33
"license": "MIT",
4-
"version": "14.0.3",
4+
"version": "14.1.1",
55
"peerDependencies": {
66
"@angular/common": ">=12.0.0",
77
"@angular/core": ">=12.0.0"

libs/mf-tools/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
{
22
"name": "@angular-architects/module-federation-tools",
3-
"version": "14.0.3",
3+
"version": "14.1.1",
44
"license": "MIT",
55
"peerDependencies": {
66
"@angular/common": ">=11.0.0",
77
"@angular/core": ">=11.0.0",
88
"@angular/router": ">=11.0.0",
9-
"@angular-architects/module-federation": "^14.0.3",
9+
"@angular-architects/module-federation": "^14.1.1",
1010
"@angular/platform-browser": ">=11.0.0",
1111
"rxjs": ">= 6.0.0"
1212
},

libs/mf/package.json

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@angular-architects/module-federation",
3-
"version": "14.0.3",
3+
"version": "14.1.1",
44
"license": "MIT",
55
"repository": {
66
"type": "GitHub",
@@ -17,12 +17,11 @@
1717
"schematics": "./collection.json",
1818
"builders": "./builders.json",
1919
"dependencies": {
20-
"@angular-architects/module-federation-runtime": "14.0.3",
20+
"@angular-architects/module-federation-runtime": "14.1.1",
2121
"word-wrap": "^1.2.3",
2222
"callsite": "^1.0.0",
23-
"node-fetch": "^2.6.1",
24-
"semver": "^7.3.5",
25-
"ngx-build-plus":"^13.0.0"
23+
"node-fetch": "^2.6.7",
24+
"semver": "^7.3.5"
2625
},
2726
"peerDependencies": {
2827
},

libs/mf/src/schematics/mf/schematic.ts

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -275,10 +275,7 @@ export default function config (options: MfSchematicSchema): Rule {
275275
updateTsConfig(tree, tsConfigName);
276276

277277
const localTsConfig = path.join(projectRoot, 'tsconfig.app.json');
278-
console.log('localTsConfig', localTsConfig);
279278
if (tree.exists(localTsConfig)) {
280-
console.log('exists');
281-
282279
updateTsConfig(tree, localTsConfig);
283280
}
284281

@@ -288,14 +285,14 @@ export default function config (options: MfSchematicSchema): Rule {
288285

289286
updatePackageJson(tree);
290287

291-
// addPackageJsonDependency(tree, {
292-
// name: 'ngx-build-plus',
293-
// type: NodeDependencyType.Dev,
294-
// version: '^13.0.1',
295-
// overwrite: true
296-
// });
288+
addPackageJsonDependency(tree, {
289+
name: 'ngx-build-plus',
290+
type: NodeDependencyType.Dev,
291+
version: '^13.0.1',
292+
overwrite: true
293+
});
297294

298-
// context.addTask(new NodePackageInstallTask());
295+
context.addTask(new NodePackageInstallTask());
299296

300297
return chain([
301298
makeMainAsync(main),

0 commit comments

Comments
 (0)