-
Notifications
You must be signed in to change notification settings - Fork 226
Open
Description
With what library do you have an issue?
native-federation
Reproduction of the bug/regression with instructions
I noticed that the skip is not always working, dug into the code and found that the skip list is not always passed through.
In my case I was trying to suppress date-fns/
, I added it in both the skip of the shareAll as well as the regular skip list, but it kept showing up (most likely through our cdk which has lots of secondary entry points)
module.exports = withNativeFederation({
name: 'app/request',
exposes: {
routes: './apps/request/src/app/app.routes.ts'
},
shared: {
...shareAll({ singleton: true, strictVersion: false, requiredVersion: 'auto' }, [
...DEFAULT_SKIP_LIST,
(pkg) => pkg.startsWith('date-fns/')
])
},
skip: [
/rxjs\/(ajax|fetch|testing|webSocket)/,
(pkg) => pkg.startsWith('date-fns/'),
...
// Add further packages you don't need at runtime
]
});
Expected behavior
When the skip list is provided, it should be used for all the skips
Versions of Native/Module Federation, Angular, Node, Browser, and operating system
Native federation: 19.0.23
Node: 20.19.2
Angular: 19.2.14
OS: Windows, macOS and Linux
Other information
Here's the PR with the fix: #902
I would be willing to submit a PR to fix this issue
- Yes
- No
Metadata
Metadata
Assignees
Labels
No labels