chore: enable strict mode

Author: arturovt

projects/elements/src/lib/lazy-elements/lazy-element-dynamic/lazy-element-dynamic.directive.ts

@@ -27,16 +27,16 @@ const LOG_PREFIX = '@angular-extensions/elements';
   selector: '[axLazyElementDynamic]',
 })
 export class LazyElementDynamicDirective implements OnInit, OnDestroy {
-  @Input('axLazyElementDynamic') tag: string;
-  @Input('axLazyElementDynamicUrl') url: string; // eslint-disable-line @angular-eslint/no-input-rename
+  @Input('axLazyElementDynamic') tag: string | null = null;
+  @Input('axLazyElementDynamicUrl') url: string | null = null; // eslint-disable-line @angular-eslint/no-input-rename
   @Input('axLazyElementDynamicLoadingTemplate') // eslint-disable-line @angular-eslint/no-input-rename
-  loadingTemplateRef: TemplateRef<any>;
+  loadingTemplateRef: TemplateRef<any> | null = null;
   @Input('axLazyElementDynamicErrorTemplate') // eslint-disable-line @angular-eslint/no-input-rename
-  errorTemplateRef: TemplateRef<any>;
-  @Input('axLazyElementDynamicModule') isModule: boolean | undefined; // eslint-disable-line @angular-eslint/no-input-rename
-  @Input('axLazyElementDynamicImportMap') importMap: boolean | undefined; // eslint-disable-line @angular-eslint/no-input-rename
+  errorTemplateRef: TemplateRef<any> | null = null;
+  @Input('axLazyElementDynamicModule') isModule = false; // eslint-disable-line @angular-eslint/no-input-rename
+  @Input('axLazyElementDynamicImportMap') importMap = false; // eslint-disable-line @angular-eslint/no-input-rename
 
-  private viewRef: EmbeddedViewRef<any> = null;
+  private viewRef: EmbeddedViewRef<any> | null = null;
   private subscription = Subscription.EMPTY;
 
   constructor(
@@ -67,9 +67,10 @@ export class LazyElementDynamicDirective implements OnInit, OnDestroy {
       }
     }
 
+    const tag = this.tag!;
+
     const elementConfig =
-      this.elementsLoaderService.getElementConfig(this.tag) ||
-      ({} as ElementConfig);
+      this.elementsLoaderService.getElementConfig(tag) || ({} as ElementConfig);
     const options = this.elementsLoaderService.options;
     const loadingComponent =
       elementConfig.loadingComponent || options.loadingComponent;
@@ -84,22 +85,22 @@ export class LazyElementDynamicDirective implements OnInit, OnDestroy {
     const loadElement$ = from(
       this.elementsLoaderService.loadElement(
         this.url,
-        this.tag,
+        tag,
         this.isModule,
         this.importMap,
         elementConfig?.hooks
       )
     );
 
     this.subscription = loadElement$
-      .pipe(mergeMap(() => customElements.whenDefined(this.tag)))
+      .pipe(mergeMap(() => customElements.whenDefined(tag)))
       .subscribe({
         next: () => {
           this.vcr.clear();
           const originalCreateElement = this.renderer.createElement;
           this.renderer.createElement = (name: string, namespace: string) => {
             if (name === 'ax-lazy-element') {
-              name = this.tag;
+              name = tag;
             }
             return this.document.createElement(name);
           };

projects/elements/src/lib/lazy-elements/lazy-element/lazy-element.directive.ts

@@ -34,13 +34,15 @@ const LOG_PREFIX = '@angular-extensions/elements';
   selector: '[axLazyElement]',
 })
 export class LazyElementDirective implements OnChanges, OnInit, OnDestroy {
-  @Input('axLazyElement') url: string;
-  @Input('axLazyElementLoadingTemplate') loadingTemplateRef: TemplateRef<any>; // eslint-disable-line @angular-eslint/no-input-rename
-  @Input('axLazyElementErrorTemplate') errorTemplateRef: TemplateRef<any>; // eslint-disable-line @angular-eslint/no-input-rename
-  @Input('axLazyElementModule') isModule: boolean | undefined; // eslint-disable-line @angular-eslint/no-input-rename
-  @Input('axLazyElementImportMap') importMap: boolean | undefined; // eslint-disable-line @angular-eslint/no-input-rename
+  @Input('axLazyElement') url: string | null = null;
+  @Input('axLazyElementLoadingTemplate') // eslint-disable-line @angular-eslint/no-input-rename
+  loadingTemplateRef: TemplateRef<any> | null = null;
+  @Input('axLazyElementErrorTemplate') // eslint-disable-line @angular-eslint/no-input-rename
+  errorTemplateRef: TemplateRef<any> | null = null;
+  @Input('axLazyElementModule') isModule = false; // eslint-disable-line @angular-eslint/no-input-rename
+  @Input('axLazyElementImportMap') importMap = false; // eslint-disable-line @angular-eslint/no-input-rename
 
-  private viewRef: EmbeddedViewRef<any> = null;
+  private viewRef: EmbeddedViewRef<any> | null = null;
   private subscription = Subscription.EMPTY;
   private url$ = new BehaviorSubject<string | null>(null);
 

projects/elements/src/lib/lazy-elements/lazy-elements-loader.service.ts

@@ -80,7 +80,7 @@ export class LazyElementsLoaderService {
     });
   }
 
-  getElementConfig(tag: string): ElementConfig {
+  getElementConfig(tag: string): ElementConfig | undefined {
     return this.configs.find((config) => config.tag === tag);
   }
 
@@ -101,7 +101,7 @@ export class LazyElementsLoaderService {
   }
 
   async loadElement(
-    url: string,
+    url: string | null,
     tag: string,
     isModule?: boolean,
     importMap?: boolean,
@@ -123,7 +123,7 @@ export class LazyElementsLoaderService {
       } else if (importMap) {
         url = tag;
       } else {
-        url = config.url;
+        url = config!.url;
       }
     }
 
@@ -192,7 +192,7 @@ export class LazyElementsLoaderService {
       this.stripUrlProtocol(url),
       new Promise<void>((resolve, reject) => (notifier = { resolve, reject }))
     );
-    return notifier;
+    return notifier!;
   }
 
   private hasElement(url: string): boolean {

projects/elements/src/lib/lazy-elements/lazy-elements.tokens.ts

@@ -22,8 +22,8 @@ export const LAZY_ELEMENTS_REGISTRY = new InjectionToken<LazyElementsRegistry>(
   }
 );
 
-export interface LazyElementsRegistry {
-  get: (url: string) => Promise<void>;
-  set: (url: string, notifier: Promise<void>) => void;
+export interface LazyElementsRegistry extends Map<string, Promise<void>> {
+  get: (url: string) => Promise<void> | undefined;
+  set: (url: string, notifier: Promise<void>) => this;
   has: (url: string) => boolean;
 }

projects/elements/tsconfig.json

@@ -0,0 +1,13 @@
+{
+  "extends": "../../tsconfig.json",
+  "files": [],
+  "include": [],
+  "references": [
+    {
+      "path": "./tsconfig.lib.json"
+    },
+    {
+      "path": "./tsconfig.spec.json"
+    }
+  ]
+}

projects/elements/tsconfig.lib.json

@@ -1,8 +1,8 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "outDir": "../../out-tsc/lib",
     "target": "es2015",
+    "strict": true,
     "declaration": true,
     "declarationMap": true,
     "inlineSources": true,