Merge pull request #1135 from angular/main

Create a new pull request by comparing changes across two branches

Author: GulajavaMinistudio

.aspect/rules/external_repository_action_cache/npm_translate_lock_MzA5NzUwNzMx

@@ -0,0 +1,8 @@
+# @generated
+# Input hashes for repository rule npm_translate_lock(name = "npm2", pnpm_lock = "@//:pnpm-lock.yaml").
+# This file should be checked into version control along with the pnpm-lock.yaml file.
+.npmrc=-2023857461
+package.json=1733430966
+pnpm-lock.yaml=-703346517
+pnpm-workspace.yaml=1711114604
+yarn.lock=-931254131

.bazelrc

@@ -1,6 +1,10 @@
 # Disable NG CLI TTY mode
 build --action_env=NG_FORCE_TTY=false
 
+# Required by `rules_ts`.
+common --@aspect_rules_ts//ts:skipLibCheck=always
+common --@aspect_rules_ts//ts:default_to_tsc_transpiler
+
 # Make TypeScript compilation fast, by keeping a few copies of the compiler
 # running as daemons, and cache SourceFile AST's to reduce parse time.
 build --strategy=TypeScriptCompile=worker
@@ -129,8 +133,6 @@ build:remote --jobs=150
 
 # Setup the toolchain and platform for the remote build execution. The platform
 # is provided by the shared dev-infra package and targets k8 remote containers.
-build:remote --crosstool_top=@npm//@angular/build-tooling/bazel/remote-execution/cpp:cc_toolchain_suite
-build:remote --extra_toolchains=@npm//@angular/build-tooling/bazel/remote-execution/cpp:cc_toolchain
 build:remote --extra_execution_platforms=@npm//@angular/build-tooling/bazel/remote-execution:platform_with_network
 build:remote --host_platform=@npm//@angular/build-tooling/bazel/remote-execution:platform_with_network
 build:remote --platforms=@npm//@angular/build-tooling/bazel/remote-execution:platform_with_network

.bazelversion

@@ -1 +1 @@
-5.4.1
+6.5.0

.eslintrc.json

@@ -75,7 +75,6 @@
     "import/newline-after-import": "error",
     "import/no-absolute-path": "error",
     "import/no-duplicates": "error",
-    "import/no-extraneous-dependencies": ["off", { "devDependencies": false }],
     "import/no-unassigned-import": ["error", { "allow": ["symbol-observable"] }],
     "import/order": [
       "error",
@@ -142,7 +141,6 @@
     {
       "files": ["!packages/**", "**/*_spec.ts"],
       "rules": {
-        "import/no-extraneous-dependencies": ["error", { "devDependencies": true }],
         "max-lines-per-function": "off",
         "no-case-declarations": "off",
         "no-console": "off"

.github/workflows/assistant-to-the-branch-manager.yml

@@ -16,6 +16,6 @@ jobs:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           persist-credentials: false
-      - uses: angular/dev-infra/github-actions/branch-manager@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+      - uses: angular/dev-infra/github-actions/branch-manager@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
         with:
           angular-robot-key: ${{ secrets.ANGULAR_ROBOT_PRIVATE_KEY }}

.github/workflows/ci.yml

@@ -21,7 +21,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Install node modules
         run: yarn install --immutable
       - name: Generate JSON schema types
@@ -42,31 +42,35 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/bazel/setup@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Install node modules
         run: yarn install --immutable
       - name: Build release targets
         run: yarn ng-dev release build
 
   test:
+    needs: build
     runs-on: ubuntu-latest
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/bazel/setup@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Install node modules
         run: yarn install --immutable
       - name: Run module and package tests
         run: yarn bazel test //modules/... //packages/...
+        env:
+          ASPECT_RULES_JS_FROZEN_PNPM_LOCK: '1'
 
   e2e:
+    needs: test
     strategy:
       fail-fast: false
       matrix:
@@ -75,12 +79,6 @@ jobs:
         subset: [npm, esbuild]
         shard: [0, 1, 2, 3, 4, 5]
         exclude:
-          # Skip yarn subset on Windows
-          - os: windows-latest
-            subset: yarn
-          # Skip pnpm subset on Windows
-          - os: windows-latest
-            subset: pnpm
           # Skip Node.js v18 tests on Windows
           - os: windows-latest
             node: 18
@@ -89,18 +87,23 @@ jobs:
             node: 20
     runs-on: ${{ matrix.os }}
     steps:
+      # Workaround for: https://github.com/bazel-contrib/bazel-lib/issues/968.
+      # TODO(devversion): Remove when Aspect lib issue is fixed.
+      - run: choco install gzip
+        if: ${{matrix.os == 'windows-latest'}}
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/bazel/setup@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Run CLI E2E tests
         run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
 
   e2e-package-managers:
+    needs: test
     strategy:
       fail-fast: false
       matrix:
@@ -111,17 +114,18 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/bazel/setup@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Run CLI E2E tests
         run: yarn bazel test --define=E2E_SHARD_TOTAL=3 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
 
   e2e-snapshots:
+    needs: test
     strategy:
       fail-fast: false
       matrix:
@@ -132,30 +136,31 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/bazel/setup@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Run CLI E2E tests
         run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.snapshots.${{ matrix.subset }}_node${{ matrix.node }}
 
   browsers:
+    needs: build
     runs-on: ubuntu-latest
     name: Browser Compatibility Tests
     env:
       SAUCE_TUNNEL_IDENTIFIER: angular-cli-${{ github.workflow }}-${{ github.run_number }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/bazel/setup@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Run E2E Browser tests
         env:
           SAUCE_USERNAME: ${{ vars.SAUCE_USERNAME }}
@@ -170,23 +175,24 @@ jobs:
           ./scripts/saucelabs/wait-for-tunnel.sh
           yarn bazel test --config=saucelabs //tests/legacy-cli:e2e.saucelabs
           ./scripts/saucelabs/stop-tunnel.sh
-      - uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
+      - uses: actions/upload-artifact@6f51ac03b9356f520e9adb1b1b7802705f340c2b # v4.5.0
         if: ${{ failure() }}
         with:
           name: sauce-connect-log
           path: ${{ env.SAUCE_CONNECT_DIR_IN_HOST }}/sauce-connect.log
 
   publish-snapshots:
+    needs: build
     runs-on: ubuntu-latest
     env:
       CIRCLE_BRANCH: ${{ github.ref_name }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+        uses: angular/dev-infra/github-actions/bazel/setup@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
       - run: yarn admin snapshots --verbose
         env:
           SNAPSHOT_BUILDS_GITHUB_TOKEN: ${{ secrets.SNAPSHOT_BUILDS_GITHUB_TOKEN }}

.github/workflows/dev-infra.yml

@@ -13,13 +13,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-      - uses: angular/dev-infra/github-actions/commit-message-based-labels@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+      - uses: angular/dev-infra/github-actions/commit-message-based-labels@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
         with:
           angular-robot-key: ${{ secrets.ANGULAR_ROBOT_PRIVATE_KEY }}
   post_approval_changes:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-      - uses: angular/dev-infra/github-actions/post-approval-changes@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+      - uses: angular/dev-infra/github-actions/post-approval-changes@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
         with:
           angular-robot-key: ${{ secrets.ANGULAR_ROBOT_PRIVATE_KEY }}

.github/workflows/feature-requests.yml

@@ -16,6 +16,6 @@ jobs:
     if: github.repository == 'angular/angular-cli'
     runs-on: ubuntu-latest
     steps:
-      - uses: angular/dev-infra/github-actions/feature-request@910c72bbcc1bf1ae2b22c48d41b2f0e8eeda520d
+      - uses: angular/dev-infra/github-actions/feature-request@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
         with:
           angular-robot-key: ${{ secrets.ANGULAR_ROBOT_PRIVATE_KEY }}

.github/workflows/perf.yml

@@ -0,0 +1,55 @@
+name: Performance Tracking
+
+on:
+  push:
+    branches:
+      - main
+      # Run workflows for all releasable branches
+      - '[0-9]+.[0-9]+.x'
+
+permissions:
+  contents: 'read'
+  id-token: 'write'
+
+defaults:
+  run:
+    shell: bash
+
+jobs:
+  list:
+    timeout-minutes: 3
+    runs-on: ubuntu-latest
+    outputs:
+      workflows: ${{ steps.workflows.outputs.workflows }}
+    steps:
+      - name: Initialize environment
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
+      - name: Install node modules
+        run: yarn install --immutable
+      - id: workflows
+        run: echo "workflows=$(yarn ng-dev perf workflows --list)" >> "$GITHUB_OUTPUT"
+
+  workflow:
+    timeout-minutes: 30
+    runs-on: ubuntu-latest
+    needs: list
+    strategy:
+      matrix:
+        workflow: ${{ fromJSON(needs.list.outputs.workflows) }}
+    steps:
+      - name: Initialize environment
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
+      - name: Setup Bazel
+        uses: angular/dev-infra/github-actions/bazel/setup@e8ee8c5c247dc83e161ab8cf2281d0f6569ee626
+      - name: Install node modules
+        run: yarn install --immutable
+      # We utilize the google-github-actions/auth action to allow us to get an active credential using workflow
+      # identity federation. This allows us to request short lived credentials on demand, rather than storing
+      # credentials in secrets long term. More information can be found at:
+      # https://docs.github.com/en/actions/security-for-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-google-cloud-platform
+      - uses: google-github-actions/auth@6fc4af4b145ae7821d527454aa9bd537d1f2dc5f # v2.1.7
+        with:
+          project_id: 'internal-200822'
+          workload_identity_provider: 'projects/823469418460/locations/global/workloadIdentityPools/measurables-tracking/providers/angular'
+          service_account: '[email protected]'
+      - run: yarn ng-dev perf workflows --name ${{ matrix.workflow }} --commit-sha ${{github.sha}}