Skip to content

Commit 53733a4

Browse files
alan-agius4alxhub
authored andcommitted
refactor(core): move static AfterRenderImpl.PHASES to a top-level variable (angular#58402)
Improves code minification. PR Close angular#58402
1 parent 2e11b6f commit 53733a4

File tree

2 files changed

+16
-11
lines changed

2 files changed

+16
-11
lines changed

packages/core/src/render3/after_render/manager.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,15 @@ export class AfterRenderManager {
3232
});
3333
}
3434

35-
export class AfterRenderImpl {
36-
static readonly PHASES = /* @__PURE__ **/ (() =>
37-
[
38-
AfterRenderPhase.EarlyRead,
39-
AfterRenderPhase.Write,
40-
AfterRenderPhase.MixedReadWrite,
41-
AfterRenderPhase.Read,
42-
] as const)();
35+
export const AFTER_RENDER_PHASES = /* @__PURE__ **/ (() =>
36+
[
37+
AfterRenderPhase.EarlyRead,
38+
AfterRenderPhase.Write,
39+
AfterRenderPhase.MixedReadWrite,
40+
AfterRenderPhase.Read,
41+
] as const)();
4342

43+
export class AfterRenderImpl {
4444
private readonly ngZone = inject(NgZone);
4545
private readonly scheduler = inject(ChangeDetectionScheduler);
4646
private readonly errorHandler = inject(ErrorHandler, {optional: true});
@@ -60,7 +60,7 @@ export class AfterRenderImpl {
6060
*/
6161
execute(): void {
6262
this.executing = true;
63-
for (const phase of AfterRenderImpl.PHASES) {
63+
for (const phase of AFTER_RENDER_PHASES) {
6464
for (const sequence of this.sequences) {
6565
if (sequence.erroredOrDestroyed || !sequence.hooks[phase]) {
6666
continue;

packages/core/src/render3/reactivity/after_render_effect.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,12 @@ import {
2525
} from '../../change_detection/scheduling/zoneless_scheduling';
2626
import {Injector} from '../../di/injector';
2727
import {inject} from '../../di/injector_compatibility';
28-
import {AfterRenderImpl, AfterRenderManager, AfterRenderSequence} from '../after_render/manager';
28+
import {
29+
AFTER_RENDER_PHASES,
30+
AfterRenderImpl,
31+
AfterRenderManager,
32+
AfterRenderSequence,
33+
} from '../after_render/manager';
2934
import {AfterRenderPhase, type AfterRenderRef} from '../after_render/api';
3035
import {NOOP_AFTER_RENDER_REF, type AfterRenderOptions} from '../after_render/hooks';
3136
import {DestroyRef} from '../../linker/destroy_ref';
@@ -177,7 +182,7 @@ class AfterRenderEffectSequence extends AfterRenderSequence {
177182
super(impl, [undefined, undefined, undefined, undefined], false, destroyRef);
178183

179184
// Setup a reactive node for each phase.
180-
for (const phase of AfterRenderImpl.PHASES) {
185+
for (const phase of AFTER_RENDER_PHASES) {
181186
const effectHook = effectHooks[phase];
182187
if (effectHook === undefined) {
183188
continue;

0 commit comments

Comments
 (0)