Skip to content

Commit 4a15ce0

Browse files
committed
refactor: rename grouping labels to avoid further confusion
The percentages of rubrics can be still misleading. It was seemingly a mistake to rename `successful-builds` to `build-failures` as the current scores of the check are 100% for "passing the rating" and "0%" for "failing the rating". NOTE (for remembering): Even though some runs were with `build-failures`, the meaning is the same as of this commit.
1 parent 0904d2f commit 4a15ce0

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

runner/ratings/built-in-ratings/no-runtime-errors-rating.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export const noRuntimeExceptionsRating: PerBuildRating = {
77
description: "Ensures the app doesn't have runtime exceptions.",
88
kind: RatingKind.PER_BUILD,
99
category: RatingCategory.HIGH_IMPACT,
10-
groupingLabels: ['functionality', 'runtime-errors', 'running-app-checks'],
10+
groupingLabels: ['functionality', 'no-runtime-errors', 'running-app-checks'],
1111
scoreReduction: '50%',
1212
id: 'common-no-runtime-errors',
1313
rate: ({buildResult, serveResult}) => ({

runner/ratings/built-in-ratings/successful-build-rating.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export const successfulBuildRating: PerBuildRating = {
88
id: 'common-successful-build',
99
kind: RatingKind.PER_BUILD,
1010
category: RatingCategory.HIGH_IMPACT,
11-
groupingLabels: ['functionality', 'build-failures'],
11+
groupingLabels: ['functionality', 'successful-builds'],
1212
scoreReduction: '50%',
1313
// Reduce the amount of points in case we've built the code with a few repair attempts.
1414
rate: ({buildResult, repairAttempts}) => ({

0 commit comments

Comments
 (0)