Skip to content

Commit 63157ef

Browse files
committed
fix: skip test repairs if runner doesn't support them
Currently we only skip build repair attempts if the runner doesn't support them, but the same should apply to the runner.
1 parent d0a4273 commit 63157ef

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

runner/orchestration/build-serve-test-loop.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,15 @@ export async function attemptBuildAndTest(
6464
progress,
6565
);
6666
let repairAttempts = 0;
67-
const maxRepairAttempts = (await env.executor.shouldRepairFailedBuilds(evalID))
68-
? (config.maxBuildRepairAttempts ?? DEFAULT_MAX_BUILD_REPAIR_ATTEMPTS)
69-
: 0;
70-
const maxTestRepairAttempts = config.maxTestRepairAttempts ?? DEFAULT_MAX_TEST_REPAIR_ATTEMPTS;
67+
let maxRepairAttempts: number;
68+
let maxTestRepairAttempts: number;
69+
70+
if (await env.executor.shouldRepairFailedBuilds(evalID)) {
71+
maxRepairAttempts = config.maxBuildRepairAttempts ?? DEFAULT_MAX_BUILD_REPAIR_ATTEMPTS;
72+
maxTestRepairAttempts = config.maxTestRepairAttempts ?? DEFAULT_MAX_TEST_REPAIR_ATTEMPTS;
73+
} else {
74+
maxRepairAttempts = maxTestRepairAttempts = 0;
75+
}
7176

7277
const initialAttempt = {
7378
outputFiles: initialResponse.files,

0 commit comments

Comments
 (0)