gh-pages 0.3.1 works, gh-pages ^0.11.0 does not. let's figure out the issue

Author: JohannesHoppe

README.md

@@ -1,13 +1,13 @@
 # angular-cli-ghpages
 
 Angular CLI addon. Publish to any gh-pages branch on GitHub (or any other branch on any other remote).  
-This is __NOT__ [IgorMinar/angular-cli-github-pages](https://github.com/IgorMinar/angular-cli-github-pages) - but inspired by it.
+This is __NOT__ [IgorMinar/angular-cli-github-pages](https://github.com/IgorMinar/angular-cli-github-pages).
 
 ## WHY?
 
 [IgorMinar/angular-cli-github-pages](https://github.com/IgorMinar/angular-cli-github-pages) is fixed to the `gh-pages` branch of the same repository. In my oponion it is also trying to do too much.
 In contrast to this, the [Angular2Buch/angular-cli-ghpages](https://github.com/Angular2Buch/angular-cli-ghpages) addon is much more simple. It pushes to any branch on any repository, by utilizing [tschaub/gh-pages](https://github.com/tschaub/gh-pages). Nothing more.
-This addon works perfectly on Travis-CI.
+This addon works great on Travis-CI.
 
 ## Installation & Setup
 
@@ -31,10 +31,18 @@ Then execute `ng ghpages` in order to deploy it.
 Usage:
 
 ```sh
-ng build --environment=production
+ng build
 ng ghpages [OPTIONS]
 ```
 
+The following command runs on our Travis-CI:
+
+```sh
+ng build --environment=production
+ng ghpages --repo=https://TheBuildbot:[email protected]/Angular2Buch/book-monkey2-public.git --name="The Buildbot" [email protected]
+```
+
+
 ## Options
 
 #### <a id="repo">--repo</a>
@@ -70,6 +78,13 @@ The name of the branch you'll be pushing to.  The default uses GitHub's `gh-page
 If you are running the command in a repository without a `user.name` or `user.email` git config properties (or on a machine without these global config properties), you must provide user info before git allows you to commit. In this case provide both `name` and `email` string values to identify the committer.
 
 
+#### <a id="silent">--silent</a>
+ * optional
+ * default: `true` (boolean)
+
+Suppress logging. With silent `true` log messages are suppressed and error messages are sanitized.
+
+> This option should be used if the repository URL or other information passed to git commands is sensitive and should not be logged.
 
 
 

deploy.js

@@ -36,6 +36,11 @@ module.exports = {
     type:         String,
     default:      undefined,  // using gh-pages default -- see readme
     description:  'The git user-email which is associated with this commit'
+  }, {
+    name:         'silent',
+    type:         Boolean,
+    default:      false,
+    description:  'Suppress console logging. This option should be used if the repository URL or other information passed to git commands is sensitive!'
   }],
   run: function(options, rawArgs) {
 
@@ -51,7 +56,7 @@ module.exports = {
       }
     };
     options.dotfiles = true;
-    options.silent = true;  // hides credentials, if provided via repo URL
+    options.logger = function(message) { ui.write(message + "\n"); }
 
     if (process.env.TRAVIS) {
       options.message += '\n\n' +
@@ -62,14 +67,21 @@ module.exports = {
     var access = publish = RSVP.denodeify(fs.access);
     var publish = RSVP.denodeify(ghpages.publish);
 
+
     return access(dir, fs.F_OK)
        .catch(function(error) {
-          ui.writeError('Dist folder does not exist. Can \'t publish anything. Run `ng build` first!');
+          ui.writeError('Dist folder does not exist. Can \'t publish anything. Run `ng build` first!\n');
           return RSVP.reject(error) ;
         })
-      .then(publish(dir, options))
       .then(function() {
-        ui.write('Successfully published!');
+        return publish(dir, options)
+      })
+      .then(function() {
+        ui.write('Successfully published!\n');
+      })
+      .catch(function(error) {
+         ui.writeError('An error occurred!\n');
+         return RSVP.reject(error) ;
       });
   }
 };

package.json

@@ -33,7 +33,7 @@
   ],
   "license": "MIT",
   "dependencies": {
-    "gh-pages": "^0.11.0",
+    "gh-pages": "^0.3.1",
     "rsvp": "^3.0.14"
   },
   "keywords": ["ember-addon", "angular2", "angular-cli", "git", "gh-pages", "ghpages"]