chore(dropdown): change to on/off

wesleycho · wesleycho · commit 08b50ccb1c2d · 2016-11-29T00:14:33.000-08:00
diff --git a/src/dropdown/dropdown.js b/src/dropdown/dropdown.js
@@ -346,7 +346,7 @@ angular.module('ui.bootstrap.dropdown', ['ui.bootstrap.position'])
         }
       };
 
-      element.bind('click', toggleDropdown);
+      element.on('click', toggleDropdown);
 
       // WAI-ARIA
       element.attr({ 'aria-haspopup': true, 'aria-expanded': false });
@@ -355,7 +355,7 @@ angular.module('ui.bootstrap.dropdown', ['ui.bootstrap.position'])
       });
 
       scope.$on('$destroy', function() {
-        element.unbind('click', toggleDropdown);
+        element.off('click', toggleDropdown);
       });
     }
   };

Original file line number	Diff line number	Diff line change
`@@ -346,7 +346,7 @@ angular.module('ui.bootstrap.dropdown', ['ui.bootstrap.position'])`
`346`	`346`	`}`
`347`	`347`	`};`
`348`	`348`
`349`		`- element.bind('click', toggleDropdown);`
	`349`	`+ element.on('click', toggleDropdown);`
`350`	`350`
`351`	`351`	`// WAI-ARIA`
`352`	`352`	`element.attr({ 'aria-haspopup': true, 'aria-expanded': false });`
`@@ -355,7 +355,7 @@ angular.module('ui.bootstrap.dropdown', ['ui.bootstrap.position'])`
`355`	`355`	`});`
`356`	`356`
`357`	`357`	`scope.$on('$destroy', function() {`
`358`		`- element.unbind('click', toggleDropdown);`
	`358`	`+ element.off('click', toggleDropdown);`
`359`	`359`	`});`
`360`	`360`	`}`
`361`	`361`	`};`