Skip to content

Commit 8e51ae4

Browse files
committed
Fix misleading references to ng-grid and a typo
1 parent ff9de89 commit 8e51ae4

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

FIRST_TIMER.md

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ In order to contribute an update your basic process is:
3131
can work, and over which you have access permissions
3232
- Clone that repository
3333
- Setup the toolset on your local machine
34-
- Make the documentation changes, and verify that they look at you had hoped
34+
- Make the documentation changes, and verify that they look as you had hoped
3535
- Run the tests to check that nothing has broken
3636
- Commit the code to git, and push the branch to your fork
3737
- Create a pull request from your fork to the upstream repository
@@ -40,11 +40,9 @@ We'll go through each step in turn.
4040

4141
### Fork the ui-grid repository ###
4242
This is the easiest step. Get yourself a github logon, and navigate to the
43-
[ui-grid github page](https://github.com/angular-ui/ng-grid). Note that the
44-
actual repository still goes by the old project name of ng-grid. Click the
43+
[ui-grid github page](https://github.com/angular-ui/ui-grid). Click the
4544
fork button in the top left. This should navigate you to your list of
46-
projects in github, with a new fork of ui-grid (also called ng-grid in your
47-
repository list).
45+
projects in github, with a new fork of ui-grid.
4846

4947
You'll see that this gives you your own issue tracker and a bunch of other content.
5048
In general you'll ignore all this, and you'll just use your fork for submitting
@@ -79,8 +77,8 @@ inside it, within the .git folder.
7977

8078
We also want to setup a link to the upstream repository, which we use when fetching
8179
the latest code version:
82-
` cd ng-grid`
83-
` git remote add upstream https://github.com/angular-ui/ng-grid.git`
80+
` cd ui-grid`
81+
` git remote add upstream https://github.com/angular-ui/ui-grid.git`
8482

8583
This allows you to get the latest code from upstream by:
8684
` git fetch upstream` or
@@ -203,7 +201,7 @@ Look through the diff listing to verify that only the changes you expected are p
203201
To commit to git, you can:
204202
` git add .`
205203
` git commit`
206-
In your commit message, follow the guidelines from [CONTRIBUTING.md](https://github.com/angular-ui/ng-grid/blob/master/CONTRIBUTING.md):
204+
In your commit message, follow the guidelines from [CONTRIBUTING.md](https://github.com/angular-ui/ui-grid/blob/master/CONTRIBUTING.md):
207205

208206
- Please adhere to these [git commit message guidelines](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
209207
or your code is unlikely be merged into the main project.
@@ -232,7 +230,7 @@ This will give you an error message, but also tell you what the real instruction
232230
copy and paste:
233231
` git push --set-upstream origin 1023_nulls_to_custom_sort`
234232

235-
Now go to your homepage in git, and to your fork of the ng-grid repository. You should see a message saying
233+
Now go to your homepage in git, and to your fork of the ui-grid repository. You should see a message saying
236234
that a new branch has been pushed, and asking if you want to create a pull request. Click that button,
237235
and check the list of changes again in the commit history, and that there is a good quality commit
238236
message with only a single commit.

0 commit comments

Comments
 (0)