Merge pull request #7180 from prx-lmo/hotfix/6388

mportuga · web-flow · commit 9031069f6082 · 2021-12-06T13:44:22.000-05:00
fix: 6388 RowSorter doesn't sort numberStr in scientific notation correctly
diff --git a/packages/core/src/js/services/rowSorter.js b/packages/core/src/js/services/rowSorter.js
@@ -122,7 +122,10 @@ module.service('rowSorter', ['uiGridConstants', function (uiGridConstants) {
 
 
   function parseNumStr(numStr) {
-    return parseFloat(numStr.replace(/[^0-9.-]/g, ''));
+    if (/^\s*-?Infinity\s*$/.test(numStr)) { // check for positive or negative Infinity and return that
+      return parseFloat(numStr);
+    }
+    return parseFloat(numStr.replace(/[^0-9.eE-]/g, ''));
   }
 
 

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,10 @@ module.service('rowSorter', ['uiGridConstants', function (uiGridConstants) {`
`122`	`122`
`123`	`123`
`124`	`124`	`function parseNumStr(numStr) {`
`125`		`- return parseFloat(numStr.replace(/[^0-9.-]/g, ''));`
	`125`	`+ if (/^\s-?Infinity\s$/.test(numStr)) { // check for positive or negative Infinity and return that`
	`126`	`+ return parseFloat(numStr);`
	`127`	`+ }`
	`128`	`+ return parseFloat(numStr.replace(/[^0-9.eE-]/g, ''));`
`126`	`129`	`}`
`127`	`130`
`128`	`131`