Skip to content

Commit 91bca52

Browse files
committed
Merge pull request #4357 from JoshuaThompson/Hide-CSV-Export-Header
Hide header in CSV export. #4307
2 parents d7a666c + 6d0d874 commit 91bca52

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/features/exporter/js/exporter.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,7 @@
606606
csvExport: function (grid, rowTypes, colTypes) {
607607
var self = this;
608608
this.loadAllDataIfNeeded(grid, rowTypes, colTypes).then(function() {
609-
var exportColumnHeaders = self.getColumnHeaders(grid, colTypes);
609+
var exportColumnHeaders = grid.options.showHeader ? self.getColumnHeaders(grid, colTypes) : [];
610610
var exportData = self.getData(grid, rowTypes, colTypes);
611611
var csvContent = self.formatAsCsv(exportColumnHeaders, exportData, grid.options.exporterCsvColumnSeparator);
612612

@@ -810,7 +810,7 @@
810810

811811
var bareHeaders = exportColumnHeaders.map(function(header){return { value: header.displayName };});
812812

813-
var csv = self.formatRowAsCsv(this, separator)(bareHeaders) + '\n';
813+
var csv = bareHeaders.length > 0 ? (self.formatRowAsCsv(this, separator)(bareHeaders) + '\n') : '';
814814

815815
csv += exportData.map(this.formatRowAsCsv(this, separator)).join('\n');
816816

src/features/exporter/test/exporter.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ describe('ui.grid.exporter uiGridExporterService', function () {
284284
var separator = ',';
285285

286286
expect(uiGridExporterService.formatAsCsv(columnHeaders, data, separator)).toEqual(
287-
"\n"
287+
""
288288
);
289289
});
290290

0 commit comments

Comments
 (0)