Skip to content

Commit b955a2d

Browse files
committed
fix(clearThisRowInvisible) not using parameter reason
Not sure if intended but clearThisRowInvisible is not using the parameter "reason" when deleting the "invisible reason" but it always deletes the hardcoded parameter "user". This shouldn't change any other behavior since ng-grid internal functions call this function only with the parameter "user" but it will fix any error if someone was directly using this function with a custom invisible reason
1 parent efd3798 commit b955a2d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/js/core/factories/GridRow.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ angular.module('ui.grid')
176176
*/
177177
GridRow.prototype.clearThisRowInvisible = function ( reason, fromRowsProcessor ) {
178178
if (typeof(this.invisibleReason) !== 'undefined' ) {
179-
delete this.invisibleReason.user;
179+
delete this.invisibleReason[reason];
180180
}
181181
this.evaluateRowVisibility( fromRowsProcessor );
182182
};
@@ -216,4 +216,4 @@ angular.module('ui.grid')
216216
return GridRow;
217217
}]);
218218

219-
})();
219+
})();

0 commit comments

Comments
 (0)