fix for #5620: runValidators function does not return a promise (#5626)

fix(5620): runValidators now returns a promise

Updated runValidator to return a promise and updated unit tests.

Issue #5620

Author: imranamans

src/features/validate/js/gridValidate.js

@@ -356,16 +356,21 @@
           };
         };
 
+        var promises = [];
+
         for (var validatorName in colDef.validators) {
           service.clearError(rowEntity, colDef, validatorName);
           var msg;
           var validatorFunction = service.getValidator(validatorName, colDef.validators[validatorName]);
           // We pass the arguments as oldValue, newValue so they are in the same order 
           // as ng-model validators (modelValue, viewValue)
-          $q.when(validatorFunction(oldValue, newValue, rowEntity, colDef))
-            .then(validateClosureFactory(rowEntity, colDef, validatorName)
-          );
+          var promise = $q
+                        .when(validatorFunction(oldValue, newValue, rowEntity, colDef))
+                        .then(validateClosureFactory(rowEntity, colDef, validatorName));
+          promises.push(promise);
         }
+        
+        return $q.all(promises);
       },
 
       /**
@@ -576,4 +581,4 @@
       }
     };
   }]);
-})();
+})();

src/features/validate/test/uiGridValidateService.spec.js

@@ -132,6 +132,28 @@ describe('ui.grid.validate uiGridValidateService', function () {
     expect(entity['$$errorstest'].foo).toBeFalsy();
 
 
+  });
+  
+  it('should return a promise when calling runValidators on a cell', function() {
+    var colDef = {name: 'test', validators: {foo: 'foo', bar: 'bar'}};
+    var entity = {};
+
+    var validatorFactory = function (argument) {return function() {return argument === 'foo';};};
+
+    uiGridValidateService.setValidator('foo', validatorFactory, angular.noop);
+    uiGridValidateService.setValidator('bar', validatorFactory, angular.noop);
+
+    var promise = uiGridValidateService.runValidators(entity, colDef, 1, 0);
+    
+    expect(promise).toBeDefined();
+
+    $rootScope.$apply();
+
+    expect(entity['$$errorstest'].bar).toBe(true);
+    expect(entity['$$invalidtest']).toBe(true);
+
+    expect(entity['$$errorstest'].foo).toBeFalsy();
+
   });
 
   it('should not execute any validator when calling runValidators with newValue === oldValue', function() {